Call `update_remaining_gas` only once

[ddoktorski]

Current State

Currently, update_remaining_gas function is called twice: in deploy_syscall and execute_inner_call. Instead it should be called only once in execute_call_entry_point as in blockifier.

Objective

Call update_remaining_gas only once

Additional Context

No response

[Abeeujah]

Hi @ddoktorski I've reviewed the files to be refactored and the call to update_remaining_gas would most likely be called in the match block match evaluate_execution_result here at the Ok variant, but a bit of a concern though, for functions where update_remaining_gas is called, remaining_gas is part of the function parameters, thus making the remaining_gas accessible for the update_remaining_gas function.

For the execute_call_entry_point, remaining_gas is not passed as a parameter, how can it be computed within the function? and if the function should be updated to take remaining_gas as a parameter as well, then what do you suggest I use the Option data type? to not affect the function usage across other points; eg rpc.rs.

Recommended by OnlyDust for exceptional experience, quality, and reliability.

[ddoktorski]

Hi @Abeeujah
Thank you for your interest in this issue. However, this is part of an ongoing effort that our team is currently working on and is not open to external contributions at this time. Issues that are available for external contributors are labeled with good first issue or help wanted.