Skip to content

Commit b69e66b

Browse files
authored
fix: config test to use reth, remove log from bound (#763)
- use reth node in config tests instead eth.llamarpc - remove log from bound fn to address foundry-rs/foundry#12478 (comment) Projects should `console.log` bounded value in tests themselves if needed
1 parent 755e679 commit b69e66b

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/StdUtils.sol

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ abstract contract StdUtils {
5757

5858
function bound(uint256 x, uint256 min, uint256 max) internal pure virtual returns (uint256 result) {
5959
result = _bound(x, min, max);
60-
console2_log_StdUtils("Bound result", result);
6160
}
6261

6362
function _bound(int256 x, int256 min, int256 max) internal pure virtual returns (int256 result) {
@@ -82,7 +81,6 @@ abstract contract StdUtils {
8281

8382
function bound(int256 x, int256 min, int256 max) internal pure virtual returns (int256 result) {
8483
result = _bound(x, min, max);
85-
console2_log_StdUtils("Bound result", vm.toString(result));
8684
}
8785

8886
function boundPrivateKey(uint256 privateKey) internal pure virtual returns (uint256 result) {

test/Config.t.sol

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {StdConfig} from "../src/StdConfig.sol";
77

88
contract ConfigTest is Test, Config {
99
function setUp() public {
10-
vm.setEnv("MAINNET_RPC", "https://eth.llamarpc.com");
10+
vm.setEnv("MAINNET_RPC", "https://reth-ethereum.ithaca.xyz/rpc");
1111
vm.setEnv("WETH_MAINNET", "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
1212
vm.setEnv("OPTIMISM_RPC", "https://mainnet.optimism.io");
1313
vm.setEnv("WETH_OPTIMISM", "0x4200000000000000000000000000000000000006");
@@ -20,7 +20,7 @@ contract ConfigTest is Test, Config {
2020
// -- MAINNET --------------------------------------------------------------
2121

2222
// Read and assert RPC URL for Mainnet (chain ID 1)
23-
assertEq(config.getRpcUrl(1), "https://eth.llamarpc.com");
23+
assertEq(config.getRpcUrl(1), "https://reth-ethereum.ithaca.xyz/rpc");
2424

2525
// Read and assert boolean values
2626
assertTrue(config.get(1, "is_live").toBool());
@@ -301,7 +301,7 @@ contract ConfigTest is Test, Config {
301301
invalidChainConfig,
302302
string.concat(
303303
"[mainnet]\n",
304-
"endpoint_url = \"https://eth.llamarpc.com\"\n",
304+
"endpoint_url = \"https://reth-ethereum.ithaca.xyz/rpc\"\n",
305305
"\n",
306306
"[mainnet.uint]\n",
307307
"valid_number = 123\n",
@@ -338,7 +338,7 @@ contract ConfigTest is Test, Config {
338338
badParseConfig,
339339
string.concat(
340340
"[mainnet]\n",
341-
"endpoint_url = \"https://eth.llamarpc.com\"\n",
341+
"endpoint_url = \"https://reth-ethereum.ithaca.xyz/rpc\"\n",
342342
"\n",
343343
"[mainnet.uint]\n",
344344
"bad_value = \"not_a_number\"\n"

0 commit comments

Comments
 (0)