Skip to content

Clear Chat is working and fixed console errors #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clear Chat is working and fixed console errors #449

wants to merge 2 commits into from

Conversation

championpaddler
Copy link
Member

Fixes #448

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

rajvaibhavdubey
rajvaibhavdubey approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@rajvaibhavdubey rajvaibhavdubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@championpaddler
Copy link
Member Author

@neeraj3029 Please merge.

@neeraj3029
Copy link
Member

@sk9331657 I wish I could but I don't have merge access. 😅

@championpaddler
Copy link
Member Author

@stealthanthrax Can you please merge this??

@championpaddler
Copy link
Member Author

@prateekiiest Can you please review and merge this??

ms10398
ms10398 requested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@ms10398 ms10398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve Conflicts

@championpaddler
Copy link
Member Author

Will make new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms10398 ms10398 ms10398 requested changes

+3 more reviewers

@neeraj3029 neeraj3029 neeraj3029 approved these changes

@samagragupta samagragupta samagragupta approved these changes

@rajvaibhavdubey rajvaibhavdubey rajvaibhavdubey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear Chat is not working and fixing console errors
5 participants
@championpaddler @neeraj3029 @ms10398 @samagragupta @rajvaibhavdubey