Skip to content

Commit 82a3575

Browse files
willnodewillnode
committed
Add (void) to empty args
1 parent aa4b7da commit 82a3575

18 files changed

+38
-36
lines changed

‎source/common/Buffer3.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ namespace Forth
1616

1717
Buffer3() { simplex = SM_Triangle; }
1818

19-
~Buffer3()
19+
~Buffer3(void)
2020
{
2121
Clear();
2222
}
2323

24-
void Clear()
24+
void Clear(void)
2525
{
2626
vertices.clear();
2727
indices.clear();

‎source/common/Buffer4.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ namespace Forth
3333
Buffer4::Buffer4()
3434
{
3535
Clean();
36+
simplex = SM_Tetrahedron;
3637
}
3738

3839
void Buffer4::Align() { offset = verticeCount; }

‎source/common/BufferGL.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ namespace Forth
1313
// Layout: 0-2 Position. 3-5 Normal
1414
std::vector<float> vb;
1515

16-
BufferGL() {}
16+
BufferGL(void) {}
1717

18-
~BufferGL()
18+
~BufferGL(void)
1919
{
2020
Clear();
2121
}
2222

23-
void Clear()
23+
void Clear(void)
2424
{
2525
vb.clear();
2626
}

‎source/common/Color.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Forth
66
{
77
float r, g, b, a;
88

9-
Color() { }
9+
Color(void) { }
1010

1111
Color(float r, float g, float b, float a) : r(r), g(g), b(b), a(a) { }
1212
};

‎source/common/VertexProfile.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace Forth
1212
Color color;
1313
Vector4 uv, uv2, uv3;
1414

15-
VertexProfile() { }
15+
VertexProfile(void) { }
1616
VertexProfile(Forth::Color c) : color(c) { }
1717
VertexProfile(Forth::Color c, Vector4 uv) : color(c), uv(uv) { }
1818
VertexProfile(Forth::Color c, Vector4 uv, Vector4 uv2) : color(c), uv(uv), uv2(uv2) { }
@@ -22,7 +22,7 @@ namespace Forth
2222
VertexProfile(Vector4 uv, Vector4 uv2) : uv(uv), uv2(uv2) { }
2323
VertexProfile(Vector4 uv, Vector4 uv2, Vector4 uv3) : uv(uv), uv2(uv2), uv3(uv3) { }
2424

25-
static VertexProfile initial()
25+
static VertexProfile initial(void)
2626
{
2727
return VertexProfile(Forth::Color(1, 1, 1, 1));
2828
}

‎source/math/Bounds4.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace Forth
1414
{
1515
Vector4 min, max;
1616

17-
Bounds4() { }
17+
Bounds4(void) { }
1818
Bounds4(const Vector4& _extent) : min(-_extent), max(_extent) { }
1919
Bounds4(const Vector4& _min, const Vector4& _max) : min(_min), max(_max) { }
2020

@@ -106,7 +106,7 @@ namespace Forth
106106
return tmax > tmin;
107107
}
108108

109-
static Bounds4 infinite()
109+
static Bounds4 infinite(void)
110110
{
111111
return Bounds4(Vector4(-INFINITY));
112112
}

‎source/math/Euler4.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace Forth
2424
/// <summary>
2525
/// Create empty euler.
2626
/// </summary>
27-
Euler4() { }
27+
Euler4(void) { }
2828

2929
/// <summary>
3030
/// Create new euler with given individual values.

‎source/math/Matrix4.h

+7-7
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace Forth
2323

2424
Vector4 ex, ey, ez, ew;
2525

26-
Matrix4() { ex = Vector4(); ey = Vector4(); ez = Vector4(); ew = Vector4(); }
26+
Matrix4(void) { ex = Vector4(); ey = Vector4(); ez = Vector4(); ew = Vector4(); }
2727

2828
Matrix4(const Vector4& _diag)
2929
{
@@ -39,12 +39,12 @@ namespace Forth
3939
Matrix4(float a, float b, float c, float d, float e, float f, float g, float h, float i, float j, float k, float l, float m, float n, float o, float p)
4040
: ex(a, b, c, d), ey(e,f,g,h), ez(i,j,k,l), ew(m,n,o,p) { }
4141

42-
Vector4& operator[](int i)
42+
inline Vector4& operator[](int i)
4343
{
4444
return (&ex)[i];
4545
}
4646

47-
Vector4 operator[](int i) const
47+
inline Vector4 operator[](int i) const
4848
{
4949
return (&ex)[i];
5050
}
@@ -54,12 +54,12 @@ namespace Forth
5454
return Vector4(ex[i], ey[i], ez[i], ew[i]);
5555
}
5656

57-
const Vector4 Column0() const
57+
const Vector4 Column0(void) const
5858
{
5959
return Vector4(ex.x, ey.x, ez.x, ew.x);
6060
}
6161

62-
const Vector4 Column1() const
62+
const Vector4 Column1(void) const
6363
{
6464
return Vector4(ex.y, ey.y, ez.y, ew.y);
6565
}
@@ -154,7 +154,7 @@ namespace Forth
154154
/// <summary>
155155
/// Get a 4x4 identity matrix
156156
/// </summary>
157-
static Matrix4 identity()
157+
static Matrix4 identity(void)
158158
{
159159
Matrix4 m = Matrix4();
160160
m.ex.x = m.ey.y = m.ez.z = m.ew.w = 1;
@@ -163,7 +163,7 @@ namespace Forth
163163

164164
private:
165165

166-
void Transpose()
166+
void Transpose(void)
167167
{
168168
float tmp;
169169
SWAP(ex.y, ey.x, tmp);

‎source/math/Plane4.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Forth
2222
/// <summary>
2323
/// Create empty plane.
2424
/// </summary>
25-
Plane4() { }
25+
Plane4(void) { }
2626

2727
/// <summary>
2828
/// Create new plane with given normal at given point.

‎source/math/Transform4.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Forth
2222
/// </summary>
2323
Matrix4 rotation;
2424

25-
Transform4() { }
25+
Transform4(void) : position(Vector4()), rotation(Matrix4()) { }
2626

2727
/// <summary>
2828
/// Create a 4x5 matrix.

‎source/math/Vector3.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ namespace Forth
1414
Vector3(float x, float y, float z) : x(x), y(y), z(z) { }
1515
Vector3(float *arr) : x(arr[0]), y(arr[1]), z(arr[2]) { }
1616

17-
float& operator[](int i)
17+
inline float& operator[](int i)
1818
{
1919
return (&x)[i];
2020
}
2121

22-
float operator[](int i) const
22+
inline float operator[](int i) const
2323
{
2424
return (&x)[i];
2525
}

‎source/math/Vector4.h

+5-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace Forth
2323
/// <summary>
2424
/// create empty vector.
2525
/// </summary>
26-
Vector4() : x(0), y(0), z(0), w(0) { }
26+
Vector4(void) : x(0), y(0), z(0), w(0) { }
2727

2828
/// <summary>
2929
/// Create uniform vector.
@@ -35,6 +35,7 @@ namespace Forth
3535
/// </summary>
3636
Vector4(int axis, float value)
3737
{
38+
x = y = z = w = 0;
3839
(&x)[axis] = value;
3940
}
4041

@@ -49,15 +50,15 @@ namespace Forth
4950
/// <summary>
5051
/// Get an axis value of specified index.
5152
/// </summary>
52-
float operator[](int i) const
53+
inline float operator[](int i) const
5354
{
5455
return (&x)[i];
5556
}
5657

5758
/// <summary>
5859
/// Set an axis value of specified index.
5960
/// </summary>
60-
float& operator[](int i)
61+
inline float& operator[](int i)
6162
{
6263
return (&x)[i];
6364
}
@@ -185,7 +186,7 @@ namespace Forth
185186
/// <summary>
186187
/// Vector with values of one.
187188
/// </summary>
188-
static Vector4 one()
189+
inline static Vector4 one(void)
189190
{
190191
return Vector4(1);
191192
}

‎source/rendering/Model4.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ namespace Forth
3333
BufferGL driver = BufferGL();
3434
Transform4 matrix;
3535

36-
Model4() : matrix(Transform4::identity()) {}
36+
Model4(void) : matrix(Transform4::identity()) {}
3737

3838
void Render(Projector4 &projector)
3939
{

‎source/rendering/Projector4.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ namespace Forth
5555
protected:
5656
void *defaultVisualizers[3];
5757

58-
Projector4();
58+
Projector4(void);
5959

60-
~Projector4();
60+
~Projector4(void);
6161

6262
public:
6363
};

‎source/rendering/Visualizer4.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Forth
99
{
1010

1111
public:
12-
Visualizer4() { }
12+
Visualizer4(void) { }
1313

1414
/// <summary>
1515
/// Marks the beginning of the visualizing function
@@ -25,7 +25,7 @@ namespace Forth
2525
/// <summary>
2626
/// Marks the end of the visualizing function
2727
/// </summary>
28-
virtual void End()
28+
virtual void End(void)
2929
{
3030
// 🤔?
3131
};

‎source/visualizer/ParticleVisualizer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Forth
99

1010
public:
1111

12-
ParticleVisualizer() { }
12+
ParticleVisualizer(void) { }
1313

1414
Buffer3 *buff;
1515

‎source/visualizer/SolidVisualizer.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Forth
77
class SolidVisualizer : public Visualizer4
88
{
99
public:
10-
SolidVisualizer();
10+
SolidVisualizer(void);
1111

1212
Buffer3 *buff;
1313

@@ -25,12 +25,12 @@ namespace Forth
2525
/// <summary>
2626
/// Marks the end of the visualizing function
2727
/// </summary>
28-
void End() override;;
28+
void End(void) override;
2929

3030
/// <summary>
3131
/// Make normal consistent so we don't get trouble with shadows.
3232
/// </summary>
33-
void RefineTriangleOrder();
33+
void RefineTriangleOrder(void);
3434

3535
Vector3 GetAverage(const std::vector<Vector3> &v);
3636
};

‎source/visualizer/WireVisualizer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Forth
77
class WireVisualizer : public Visualizer4
88
{
99
public:
10-
WireVisualizer() { }
10+
WireVisualizer(void) { }
1111

1212
Buffer3 *buff;
1313

0 commit comments

Comments
 (0)