User creates long field name in R and ForSys cannot run

[michelledayusfs]

This is easy for the user to fix but the error that comes out of ForSysXR is maybe unclear. If I create a new field and add it to my spatial object in R, and call it, "forest_departure", ForSys can not use this field because it is longer than 10 characters. I'm not sure how you would fix this and if the check_input_shapefile function looks for this as well. Knowing people, they may not run that function... but we can always encourage best practices.

Error R returns:
Error in file(file, "rt") : cannot open the connection
In addition: Warning messages:
1: In abbreviate_shapefile_names(obj) :
Field names abbreviated for ESRI Shapefile driver
2: In file(file, "rt") :

Error in file(file, "rt") : cannot open the connection

[bmaparicio]

The easiest solution is to abbreviate all field names with more than 10 characters, while also ensuring that they remain unique. Then report a warning saying that the field name was abbreviated. Would this work?

[bmaparicio]

This was harder than I expected. If I change the names in the set_forsys_run then the XML was looking for fields that did not exist (like my_field_12345, but this was changed to my_field to keep the N characters below 10).
The solution I found was to add the possibility to change the fields in the check_input_shapefile function. It is always a good idea to run this function before a forsys run.
If still the user wants to run set_forsys_run with at least one field named with more than 10 characters, then the function will report an error.

Will this work for now?
There is also the possibility to change the field name and update the settings used in the parameters of set_forsys_run to make sure the XML is created with the correct field names. But it will require more time to solve. I have an idea that should work, but I want to avoid going there if possible.