File diff does not load for some images

[saket]

For some images, Fork seems to be unable to display a diff when they're updated. Here's one example: saket/telephoto@a19a646#diff-f9ca815bc1be6c794660be9f815c75fdb6696bd18c0b1993ba856d9bb801bae9

Before staging	After staging

[DanPristupov]

Here's one example

What should I do to reproduce the problem on this example?

[saket]

Sorry I should have mentioned that, can you try viewing that commit by checking out the project in fork?

[DanPristupov]

Yes. Every commit looks correctly:

[saket]

What happens if you make some changes to that image without staging it? Does the diff show up in the preview pane?

[DanPristupov]

Yes,

Does the log file has any errors. The log is located at ~/Library/Logs/Fork.log

[saket]

Here you go: Fork.log. And here's the image that you can add to my project to reproduce the bug. Its path will be:

zoomable-image/core/src/androidTest/screenshots/image_without_an_intrinsic_size_zoomed_in.png

[DanPristupov]

Yes, I see the changes.

It looks like LFS is not properly initialized in this repo. Try to run Repository -> LFS -> Initialize (if available) and Repository -> LFS -> Pull.

[saket]

Huh, so weird.

If LFS were the issue, shouldn't I be seeing this error in all images then? I'm only seeing this error for 2-3 images. The error disappears when I stage the file (shown in the screenshot in the first post).

[DanPristupov]

It could be that some of the files on your machine are not under LFS.

If comment out content of .gitattributes (which effectively disables LFS for new files), I see same result as you:

[saket]

Gotcha. Do you think Fork could display an error message for surfacing this information?

[DanPristupov]

Yes, may be it's possible.