From fcd98531ef1d91f02366dc8e46207e91d194a005 Mon Sep 17 00:00:00 2001 From: Maccabee Levine Date: Thu, 9 Oct 2025 16:02:22 -0400 Subject: [PATCH 1/2] Require the TC Module Eval tool --- MODULE_ACCEPTANCE_CRITERIA.MD | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/MODULE_ACCEPTANCE_CRITERIA.MD b/MODULE_ACCEPTANCE_CRITERIA.MD index 939565c..e4c39d4 100644 --- a/MODULE_ACCEPTANCE_CRITERIA.MD +++ b/MODULE_ACCEPTANCE_CRITERIA.MD @@ -58,11 +58,9 @@ Use these conventions to indicate the status of each criterion. * [ ] Uses Apache 2.0 license (2) * [ ] Module build MUST produce a valid module descriptor (3, 5) * _This is not applicable to libraries_ -* [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html) (2) - * Uses README for [Category B Appropriately Labelled Condition](https://apache.org/legal/resolved.html#appropriately-labelled-condition) - * org.z3950.zing:cql-java is allowed if appropriately labelled, even if it is LGPL-2.1-only - * org.marc4j:marc4j is allowed if appropriately labelled, even if it is LGPL-2.1-or-later - * org.hibernate.* is allowed if appropriately labelled, even if it is LGPL-2.1-or-later +* [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html), as defined and reported by the [FOLIO Module Evaluator](https://github.com/folio-org/tc-module-eval) tool (2) + * GitHub Actions automated evaluation result page shows a passing evaluation. + * _note: See [license-categories.json](https://github.com/folio-org/tc-module-eval/blob/master/config/license-categories.json) for licenses which are allowed (Category A), prohibited (Category X), and allowed when [appropriately labelled in the module's README](https://apache.org/legal/resolved.html#appropriately-labelled-condition) (Category B-WCL). See [special-exceptions.json](https://github.com/folio-org/tc-module-eval/blob/master/config/special-exceptions.json) for permitted exceptions._ * _note: If a library declares multiple licenses in its pom.xml, [only one of them needs to comply](https://maven.apache.org/ref/3.9.11/maven-model/maven.html#project)._ * [ ] Installation documentation is included (11) * -_note: read more at https://github.com/folio-org/mod-search/blob/master/README.md_ From b891ec041467d8635a55fdfe93ea262378db5ea6 Mon Sep 17 00:00:00 2001 From: Maccabee Levine Date: Thu, 13 Nov 2025 16:05:59 -0500 Subject: [PATCH 2/2] Add back missing note from CC --- MODULE_ACCEPTANCE_CRITERIA.MD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MODULE_ACCEPTANCE_CRITERIA.MD b/MODULE_ACCEPTANCE_CRITERIA.MD index 55a2a15..e9445c8 100644 --- a/MODULE_ACCEPTANCE_CRITERIA.MD +++ b/MODULE_ACCEPTANCE_CRITERIA.MD @@ -61,7 +61,7 @@ Use these conventions to indicate the status of each criterion. * _This is not applicable to libraries_ * [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html), as defined and reported by the [FOLIO Module Evaluator](https://github.com/folio-org/tc-module-eval) tool (2) * GitHub Actions automated evaluation result page shows a passing evaluation. - * _note: See [license-categories.json](https://github.com/folio-org/tc-module-eval/blob/master/config/license-categories.json) for licenses which are allowed (Category A), prohibited (Category X), and allowed when [appropriately labelled in the module's README](https://apache.org/legal/resolved.html#appropriately-labelled-condition) (Category B-WCL). See [special-exceptions.json](https://github.com/folio-org/tc-module-eval/blob/master/config/special-exceptions.json) for permitted exceptions._ + * _note: See [license-categories.json](https://github.com/folio-org/tc-module-eval/blob/master/config/license-categories.json) for licenses which are allowed (Category A), prohibited (Category X), and allowed when [appropriately labelled in the module's README](https://apache.org/legal/resolved.html#appropriately-labelled-condition) (Category B-WCL). See [special-exceptions.json](https://github.com/folio-org/tc-module-eval/blob/master/config/special-exceptions.json) for permitted exceptions. By [request of the Community Council](https://folio-org.atlassian.net/wiki/spaces/CC/pages/1243348996/2025-09-26+Community+Council+Meeting+Minutes+at+WOLFcon), and until that request changes, no additional LGPL-licensed dependencies will be allowed._ * _note: If a library declares multiple licenses in its pom.xml, [only one of them needs to comply](https://maven.apache.org/ref/3.9.11/maven-model/maven.html#project)._ (This applies only to Maven. For other package managers, closer evaluation is needed.) * _note: [More information about this criterion](https://github.com/folio-org/tech-council/blob/master/criteria/THIRD_PARTY_DEPENDENCIES.MD)_ * [ ] Installation documentation is included (11)