From edc5a401cca0767d9dea1d1ba542fb58d1b6332a Mon Sep 17 00:00:00 2001
From: Olamide Kolawole <okolawole@ebsco.com>
Date: Thu, 23 Oct 2025 12:59:46 -0500
Subject: [PATCH 1/2] Remove no_cleanup input and related logic from module
 evaluation workflow

---
 .github/workflows/module-evaluation.yml | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/.github/workflows/module-evaluation.yml b/.github/workflows/module-evaluation.yml
index 31cb862..43f1849 100644
--- a/.github/workflows/module-evaluation.yml
+++ b/.github/workflows/module-evaluation.yml
@@ -27,11 +27,6 @@ on:
         required: false
         type: string
         default: ''
-      no_cleanup:
-        description: 'Keep cloned repository for inspection (do not delete after evaluation)'
-        required: false
-        type: boolean
-        default: false
       custom_output_dir:
         description: 'Custom output directory for reports'
         required: false
@@ -136,11 +131,6 @@ jobs:
             ARGS="$ARGS --criteria ${{ inputs.criteria_filter }}"
           fi
 
-          # Add no-cleanup flag if requested
-          if [ "${{ inputs.no_cleanup }}" = "true" ]; then
-            ARGS="$ARGS --no-cleanup"
-          fi
-
           echo "cli_args=$ARGS" >> $GITHUB_OUTPUT
           echo "normalized_output_dir=$OUTPUT_DIR" >> $GITHUB_OUTPUT
           echo "Prepared CLI arguments: $ARGS"
@@ -154,7 +144,6 @@ jobs:
           echo "Output format: ${{ inputs.output_format }}"
           echo "Output directory: ${{ inputs.custom_output_dir }}"
           echo "Criteria filter: ${{ inputs.criteria_filter }}"
-          echo "No cleanup: ${{ inputs.no_cleanup }}"
           echo ""
 
           # Run the evaluation
@@ -206,13 +195,4 @@ jobs:
           name: folio-module-evaluation-reports
           path: ${{ steps.prepare-args.outputs.normalized_output_dir }}/
           retention-days: 90
-          if-no-files-found: warn
-
-      - name: Upload cloned repository (if no-cleanup enabled)
-        uses: actions/upload-artifact@v4
-        if: inputs.no_cleanup == true
-        with:
-          name: cloned-repository-for-inspection
-          path: temp/
-          retention-days: 30
-          if-no-files-found: ignore
\ No newline at end of file
+          if-no-files-found: warn
\ No newline at end of file

From b08dc403ea570551137e45fc20f2af663956c9ad Mon Sep 17 00:00:00 2001
From: Olamide Kolawole <okolawole@ebsco.com>
Date: Thu, 23 Oct 2025 13:02:54 -0500
Subject: [PATCH 2/2] Remove custom_output_dir input from module evaluation
 workflow

Simplify the workflow by removing the custom output directory feature. The
output directory is now hardcoded to 'reports' as the default location for
all evaluation reports.

Changes:
- Removed custom_output_dir input parameter from workflow_dispatch.inputs
- Removed output directory normalization logic and hardcoded to 'reports'
- Removed echo statement showing custom output directory
- Updated output directory variable reference from normalized_output_dir to output_dir
---
 .github/workflows/module-evaluation.yml | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/module-evaluation.yml b/.github/workflows/module-evaluation.yml
index 43f1849..c66efd6 100644
--- a/.github/workflows/module-evaluation.yml
+++ b/.github/workflows/module-evaluation.yml
@@ -27,11 +27,6 @@ on:
         required: false
         type: string
         default: ''
-      custom_output_dir:
-        description: 'Custom output directory for reports'
-        required: false
-        type: string
-        default: './reports'
 
 jobs:
   evaluate-module:
@@ -100,10 +95,7 @@ jobs:
         id: prepare-args
         run: |
           ARGS="${{ inputs.repository_url }}"
-
-          # Normalize output directory (remove leading ./ if present)
-          OUTPUT_DIR="${{ inputs.custom_output_dir }}"
-          OUTPUT_DIR="${OUTPUT_DIR#./}"  # Remove leading ./
+          OUTPUT_DIR="reports"
 
           # Add output directory
           ARGS="$ARGS --output $OUTPUT_DIR"
@@ -132,9 +124,9 @@ jobs:
           fi
 
           echo "cli_args=$ARGS" >> $GITHUB_OUTPUT
-          echo "normalized_output_dir=$OUTPUT_DIR" >> $GITHUB_OUTPUT
+          echo "output_dir=$OUTPUT_DIR" >> $GITHUB_OUTPUT
           echo "Prepared CLI arguments: $ARGS"
-          echo "Normalized output directory: $OUTPUT_DIR"
+          echo "Output directory: $OUTPUT_DIR"
 
       - name: Run module evaluation
         run: |
@@ -142,7 +134,6 @@ jobs:
           echo "Repository: ${{ inputs.repository_url }}"
           echo "Branch: ${{ inputs.branch || '(default)' }}"
           echo "Output format: ${{ inputs.output_format }}"
-          echo "Output directory: ${{ inputs.custom_output_dir }}"
           echo "Criteria filter: ${{ inputs.criteria_filter }}"
           echo ""
 
@@ -166,12 +157,12 @@ jobs:
         run: |
           echo "📊 Evaluation completed!"
           echo ""
-          echo "📁 Generated files in ${{ steps.prepare-args.outputs.normalized_output_dir }}:"
-          find ${{ steps.prepare-args.outputs.normalized_output_dir }} -type f -name "*.html" -o -name "*.json" | head -20
+          echo "📁 Generated files in ${{ steps.prepare-args.outputs.output_dir }}:"
+          find ${{ steps.prepare-args.outputs.output_dir }} -type f -name "*.html" -o -name "*.json" | head -20
           echo ""
 
           # Show JSON summary if available
-          JSON_FILE=$(find ${{ steps.prepare-args.outputs.normalized_output_dir }} -name "*.json" | head -1)
+          JSON_FILE=$(find ${{ steps.prepare-args.outputs.output_dir }} -name "*.json" | head -1)
           if [ -f "$JSON_FILE" ]; then
             echo "📈 Evaluation Summary:"
             # Extract key metrics from JSON using jq if available, otherwise use basic tools
@@ -193,6 +184,6 @@ jobs:
         if: always()
         with:
           name: folio-module-evaluation-reports
-          path: ${{ steps.prepare-args.outputs.normalized_output_dir }}/
+          path: ${{ steps.prepare-args.outputs.output_dir }}/
           retention-days: 90
           if-no-files-found: warn
\ No newline at end of file