fix(packages): validate blank url and remove invalid format checks (#721)

Closes: MODKBEKBJ-863

Author: psmagin

NEWS.md

@@ -13,6 +13,7 @@
 * Remove HTML validation for package's custom display name field ([MODKBEKBJ-855](https://folio-org.atlassian.net/browse/MODKBEKBJ-855))
 * Add access types to eholdings/providers/{id}/packages response ([MODKBEKBJ-839](https://folio-org.atlassian.net/browse/MODKBEKBJ-839))
 * Sanitize HTML content for the package description field ([MODKBEKBJ-860](https://folio-org.atlassian.net/browse/MODKBEKBJ-860))
+* Validate blank package url and remove invalid format checks ([MODKBEKBJ-863](https://folio-org.atlassian.net/browse/MODKBEKBJ-863))
 
 ### Bug fixes
 * Fix offset handling when retrieving holdings from HoldingsIQ. ([MODKBEKBJ-825](https://folio-org.atlassian.net/browse/MODKBEKBJ-825))

src/main/java/org/folio/rest/validator/packages/PackageCustomAttributesValidator.java

@@ -58,8 +58,8 @@ private void validateUrl(String url) {
     if (url == null) {
       return;
     }
+    ValidatorUtil.checkIsNotBlank("url", url);
     ValidatorUtil.checkMaxLength("url", url, MAX_URL_LENGTH);
-    ValidatorUtil.checkUrlFormat("url", url);
   }
 
   private void validateCustomCoverage(Coverage coverage) {

src/test/java/org/folio/rest/validator/packages/PackageCustomAttributesValidatorTest.java

@@ -127,23 +127,17 @@ void shouldNotThrowWhenUrlIsValid() {
   }
 
   @Test
-  void shouldThrowWhenUrlHasNoProtocol() {
-    var customAttributes = withUrl("example.com");
-    assertThrows(InputValidationException.class, () -> validator.validate(customAttributes));
+  void shouldNotThrowWhenUrlIsNull() {
+    var customAttributes = withUrl(null);
+    assertDoesNotThrow(() -> validator.validate(customAttributes));
   }
 
   @Test
-  void shouldThrowWhenUrlIsInvalidFormat() {
-    var customAttributes = withUrl("not a url");
+  void shouldThrowWhenUrlIsBlank() {
+    var customAttributes = withUrl("   ");
     assertThrows(InputValidationException.class, () -> validator.validate(customAttributes));
   }
 
-  @Test
-  void shouldNotThrowWhenUrlIsNull() {
-    var customAttributes = withUrl(null);
-    assertDoesNotThrow(() -> validator.validate(customAttributes));
-  }
-
   @Test
   void shouldNotThrowWhenCustomCoverageIsNull() {
     var customAttributes = withCoverage(null);