Library functions on Instant Actions block Quick Actions

[tvolin]

I posted this as a NexusMods comment, but I'm restating it here for you.
If you map a LIBRARY function (in my case, the Map) to an INSTANT action (in my case, on Y), it performs the library action even when the Item or Mod wheel is pulled up, taking precedence over the assigned quick action (in my case, the H key, to load the bulletin board, thanks to UI Info Suite 2).
If I put a mod function or an inventory item on the Instant action for Y, then the quick action for Y still works as expected. It's only broken when the Instant action is a Library action (maybe even only when it's the Map action).
This is easy to reproduce, but I'm happy to turn on Debug and send a smap.io log if you wish.
(before you ask: everything - Stardew UI, Star Controls, SMAPI, GMCM, etc. - is up to date as of this moment)

[focustense]

Strange set of circumstances, as far as I know there's no code that should take into account what type of action is mapped to an instant action, and in fact the input handlers have no idea what kind of action it is.

Might be that the bug does not happen in other circumstances because of a coincidence, like other instant actions not being available and falling through to quick.

Want to confirm your repro steps here:

1. Assign Map action to Y button (instant)
2. Assign H button/Bulletin Board to Y button (quick)
3. Press Y while controller overlay is open.

Is that right?

[tvolin]

That's exactly right. I can't imagine it matters that the H button assigned to a Mod function was done using GMCM sync, but I thought I would throw that out there.
I will also try a few permutations (library function other than Map, using a Tool and/or Edible on the Quick function instead of a Mod function, etc.) and I'll let you know if that changes anything.

[tvolin]

Okay, here's what I've found with experiments. All using Y.
All permutations of tool/key/libraryFunction on Instant/Quick.
*** means interesting result.

• Tool (Axe) on instant, Tool (melee) on Quick:
  Works as expected

• *** Tool (Axe) on Instant, Mod Action (key Z) on Quick:
  Hitting Y chops the axe. Trigger + Y does BOTH the mod action and the chop

• Tool (Axe) on Instant, Library function (Map) on Quick:
  Works as expected

• Mod Action (key Z) on Instant, Tool (axe) on Quick:
  Works as expected. Trigger + Y only switches to axe, it does not activate the mod action

• *** Mod action (key Z) on Instant, Mod action (key H) on Quick:
  Trigger + Y does BOTH mod actions [for me, Z freezes time which causes a notification, and H pulls up the bulletin board. Both happen.]

• Mod action (key Z) on Instant, library function (Map) on Quick):
  Works as expected

• Library function (Map) on Instant, Tool (axe) on Quick:
  Works as expected

• *** Library function (Map) on Instant, Mod action (key Z) on Quick:
  This is the original bug report! I can be more specific now. Map is pulled up regardless of trigger. AND, key Z is never pressed, regardless of trigger.

• Library function (Map) on Instant, Library function (Quest Log) on Quick:
  Works as expected.

[tvolin]

I tried to take a look at this myself. It appears there's no logging whatsoever on Instant Actions (with Debug Everything enabled).
I couldn't even find in the code where the entire instant action behavior would take place (suppress "B" pressed, ActivateOrConsume switching to my sword and swinging it, and updating the current Toolbar tab to the one containing the sword).
I'd like to help / provide better feedback. But I'm not sure I can.

What brought me back here is that I just installed Chests Everywhere.
For some reason, when I close a chest menu with "B" normally, it does not trigger my sword-swing. But with Chests Everywhere it does. So I went looking at the StarControllers source to see how it is detecting when to suppress the Instant Action (coming out of a chest menu), to see what Chests Everywhere is doing "wrong". But I could not figure out anything related to Instant Actions.
Oddly, if I use button Y to exit the menu (which I didn't even realize it would), it does not trigger my "hoe" instant action.
If I swap the instant actions (sword/hoe), the behavior sticks with the buttons. That is, instant action on "B" get sent through after chest closes, regardless of what that instant action was.