Handle remapped button patch reversion and button release action separately.

We were previously using the `downButtons` to undo the patch, but since the logic had been (intentionally) changed to apply the patch even when not starting a continuous-activation cycle (i.e. due to `!Context.IsPlayerFree`), the patch wasn't always getting undone when the button was released.

The new logic checks both states separately, and undoes the patch if the button is physically up, regardless of whether it was tracked.

Also adds a custom activation action to end fishing, which seems to help with a few hard-to-identify edge cases where the default `pressToolButton` logic behaves oddly, either failing to clear the menu or doing a duplicate cast or "catching" the wrong fish/item.

Author: focustense

StarControl/Menus/InventoryMenuItem.cs

@@ -71,7 +71,12 @@ ItemActivationType activationType
                 }
                 who.CurrentToolIndex = who.Items.IndexOf(tool);
             }
-            if (tool is not MeleeWeapon)
+            if (tool is FishingRod rod && rod.fishCaught)
+            {
+                rod.doneHoldingFish(who);
+                return ItemActivationResult.Used;
+            }
+            else if (tool is not MeleeWeapon)
             {
                 who.FireTool();
             }

StarControl/Menus/RemappingController.cs

@@ -66,20 +66,22 @@ public void Update(TimeSpan elapsed, bool isMenuActive)
         {
             var controllerButton = button.TryGetController(out var cb) ? cb : default;
             var buttonState = inputHelper.GetState(button);
-            if (downButtons.Contains(button))
+            var wasButtonDown = downButtons.Contains(button);
+            var wasPatched = InputPatches.ToolUseButton == controllerButton;
+            if (wasButtonDown || wasPatched)
             {
-                if (
+                var isButtonUp =
                     !inputHelper.IsSuppressed(button)
-                    && buttonState is SButtonState.Released or SButtonState.None
-                )
+                    && buttonState is SButtonState.Released or SButtonState.None;
+                // We have to release the simulated tool button as soon as the remapped button
+                // is released, because some tools won't allow release until *after* they detect
+                // that the tool button is released.
+                if (wasPatched && isButtonUp)
+                {
+                    InputPatches.ToolUseButton = null;
+                }
+                if (wasButtonDown && isButtonUp)
                 {
-                    // We have to release the simulated tool button as soon as the remapped button
-                    // is released, because some tools won't allow release until *after* they detect
-                    // that the tool button is released.
-                    if (InputPatches.ToolUseButton == controllerButton)
-                    {
-                        InputPatches.ToolUseButton = null;
-                    }
                     if (item.EndActivation())
                     {
                         downButtons.Remove(button);