Skip to content

fix(devbox): match FLYTE_DEV case-insensitively in bootstrap - #8236

Merged
Sovietaced merged 1 commit into
flyteorg:mainfrom
Icewind52:fix/devbox-flyte-dev-case-insensitive
Oct 24, 2026
Merged

Sovietaced merged 1 commit into
flyteorg:mainfrom
Icewind52:fix/devbox-flyte-dev-case-insensitive

Conversation

@Icewind52

@Icewind52 Icewind52 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Tracking issue

Closes #8231

Why are the changes needed?

Follow-up to #8232, from this review comment. Bootstrap only enables dev mode when FLYTE_DEV is exactly True, so FLYTE_DEV=true silently starts the in-cluster manager. flyte start devbox already reads the value back case-insensitively.

What changes were proposed in this pull request?

How was this patch tested?

Unit tests: go test ./... in docker/devbox-bundled/bootstrap. TestIsDevMode covers True/true/TRUE (dev mode) and False/false/empty/1 (not dev mode); the true and TRUE cases fail against the previous == "True" check.

End-to-end:

  1. make devbox-build from this branch, then make devbox-run FLYTE_DEV=true (lowercase) and make devbox-run FLYTE_DEV=True (Uppercase)
  2. kubectl get pods -n flyte: no flyte-binary pod
  3. make -C manager run and a hello-world run (1 parent + 10 child tasks): all 11 TaskActions completed; the manager log shows a single TaskAction controller and no Operation cannot be fulfilled conflicts

Labels

  • fixed

Setup process

N/A

Screenshots

N/A

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#8232

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

N/A

Closes flyteorg#8231

Signed-off-by: William Tang <williamtang83@hotmail.com>
@Icewind52

Icewind52 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

tagging @pingsutw for review as this is a follow-up to #8232

@Sovietaced
Sovietaced merged commit 9112dd4 into flyteorg:main Oct 24, 2026
24 checks passed
@Icewind52
Icewind52 deleted the fix/devbox-flyte-dev-case-insensitive branch October 24, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V2] FLYTE_DEV=true from CONTRIBUTING.md doesn't enable devbox dev mode

2 participants