Repository navigation
fix(devbox): match FLYTE_DEV case-insensitively in bootstrap - #8236
Merged
Sovietaced merged 1 commit intoOct 24, 2026
Merged
Conversation
Closes flyteorg#8231 Signed-off-by: William Tang <williamtang83@hotmail.com>
Contributor
Author
Sovietaced
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #8231
Why are the changes needed?
Follow-up to #8232, from this review comment. Bootstrap only enables dev mode when
FLYTE_DEVis exactlyTrue, soFLYTE_DEV=truesilently starts the in-cluster manager.flyte start devboxalready reads the value back case-insensitively.What changes were proposed in this pull request?
FLYTE_DEVagainsttruecase-insensitively (strings.EqualFold) in a smallisDevMode()helper, consistent with the SDK.TestIsDevMode.CONTRIBUTING.mdin docs: use FLYTE_DEV=True to enable devbox dev mode #8232.How was this patch tested?
Unit tests:
go test ./...indocker/devbox-bundled/bootstrap.TestIsDevModecoversTrue/true/TRUE(dev mode) andFalse/false/empty/1(not dev mode); thetrueandTRUEcases fail against the previous== "True"check.End-to-end:
make devbox-buildfrom this branch, thenmake devbox-run FLYTE_DEV=true(lowercase) andmake devbox-run FLYTE_DEV=True(Uppercase)kubectl get pods -n flyte: noflyte-binarypodmake -C manager runand a hello-world run (1 parent + 10 child tasks): all 11 TaskActions completed; the manager log shows a single TaskAction controller and noOperation cannot be fulfilledconflictsLabels
Setup process
N/A
Screenshots
N/A
Check all the applicable boxes
Related PRs
#8232
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link
N/A