feat: Remove deprecated object metrics from controllers fluxcd/flux2#5083

hasithsen · hasithsen · commit ff7cfc1d7a21 · 2024-12-12T00:50:33.000+05:30
Signed-off-by: hasithsen &lt;sen.hasith@gmail.com&gt;
diff --git a/internal/controller/imagepolicy_controller.go b/internal/controller/imagepolicy_controller.go
@@ -174,8 +174,7 @@ func (r *ImagePolicyReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 			retErr = kerrors.NewAggregate([]error{retErr, err})
 		}
 
-		// Always record readiness and duration metrics.
-		r.Metrics.RecordReadiness(ctx, obj)
+		// Always record duration metrics.
 		r.Metrics.RecordDuration(ctx, obj, start)
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,7 @@ func (r *ImagePolicyReconciler) Reconcile(ctx context.Context, req ctrl.Request)`
`174`	`174`	`retErr = kerrors.NewAggregate([]error{retErr, err})`
`175`	`175`	`}`
`176`	`176`
`177`		`- // Always record readiness and duration metrics.`
`178`		`- r.Metrics.RecordReadiness(ctx, obj)`
	`177`	`+ // Always record duration metrics.`
`179`	`178`	`r.Metrics.RecordDuration(ctx, obj, start)`
`180`	`179`	`}()`
`181`	`180`