Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flux2] support containerName for deployments can be customised #230

Open
lkaluza-fadi opened this issue Oct 9, 2024 · 2 comments · May be fixed by #233
Open

[flux2] support containerName for deployments can be customised #230

lkaluza-fadi opened this issue Oct 9, 2024 · 2 comments · May be fixed by #233
Labels
enhancement New feature or request

Comments

@lkaluza-fadi
Copy link

lkaluza-fadi commented Oct 9, 2024 •
edited
Loading

Is your feature request related to a problem ?

Currently all containerNames in a flux deployment/pods are called manager. As we are using datadog as a monitoring tool its hard to figure out which container has maybe some resource issues because they are all named the same.

Describe the solution you'd like.

We would like to have the option to configure the name of the container in the helm_release like:

helmController:
  container:
    name: <some-container-name>
sourceController:
  container:
    name: <some-container-name>
etc...

Describe alternatives you've considered.

None

Additional context.

No response
@lkaluza-fadi lkaluza-fadi added the enhancement New feature or request label Oct 9, 2024
@lkaluza-fadi lkaluza-fadi linked a pull request Oct 22, 2024 that will close this issue
Open
6 tasks
@stefanprodan
Copy link
Member

Datadog should add the deployment name to its report, the manager naming is a convention we have in Flux upstream and this chart should be as close as possible to it.

@lkaluza-fadi
Copy link
Author

@stefanprodan I don't understand the connection between the flux upstream and the name of the Kubernetes resources like container name. Could you elaborate this a bit more? Is it realy not possible to have an option of configuring different names and having the default as manager?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(charts/flux2): adding option for container.name fadi-cloudarchitecture/flux-helm-charts
2 participants
@stefanprodan @lkaluza-fadi