Skip to content

Windows containers failing to build #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrick-stephens opened this issue Apr 1, 2025 · 1 comment
Open

Windows containers failing to build #10158

patrick-stephens opened this issue Apr 1, 2025 · 1 comment

Comments

@patrick-stephens
Copy link
Contributor

Windows 2019 failed here https://github.com/fluent/fluent-bit/actions/runs/14178178470/job/39718022548#step:5:2710 because that plugin uses flb_plg_trace which in turn uses FLB_FILENAME which apparently is not defined in this environment.

@leonardo-albertovich thinks the root cause of it is we're adding the definition in the global CMakeLists.txt file here using the gcc/clang compatible command line flag unconditionally instad of doing it in the previous conditional where we could use /D__FLB_FILENAME__=FILE for msvc and -D__FLB_FILENAME__=FILE for the rest.

@mabrarov
Copy link
Contributor

mabrarov commented Apr 7, 2025

Hi @patrick-stephens,

By some reason when using NMake Makefiles CMake generator (I can be wrong, but I feel it was documentation recommended way of building Fluent Bit on Windows 1-2 years ago), then this issue doesn't happen. Refer to #10180.

IMHO, Fluent Bit CMake project (including its sub-projects) can be not ready for CMake multi-configuration generators (as opposite to single-configuration generators). Such CMake generators require usage of CMake generator expressions - refer to https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#build-configurations.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants