From 4769f2e0d1e1fb4f8af59e2de36e3974cc361ff8 Mon Sep 17 00:00:00 2001 From: Tom Bereknyei Date: Tue, 14 Nov 2023 17:00:23 -0500 Subject: [PATCH 1/7] ci: run tests on self-hosted runners --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cde2da4..7b5e75d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,13 +17,15 @@ jobs: test-javascript: name: "JavaScript Tests" - runs-on: "${{ matrix.os }}" + runs-on: ${{ matrix.os }} strategy: matrix: os: - "ubuntu-latest" - "macos-latest" + - [ self-hosted linux arm64 ] + - [ self-hosted linux x86 ] steps: - name: "Checkout" From 8be5dfcbce55dfb519085950e8445c582edbdd69 Mon Sep 17 00:00:00 2001 From: Rok Garbas Date: Wed, 15 Nov 2023 12:02:46 +0100 Subject: [PATCH 2/7] adding self-hosted to other tests --- .github/workflows/ci.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b5e75d..b4ba0a8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,13 +61,15 @@ jobs: test-minimal-action: name: "Minimal - Github Action Test" - runs-on: "${{ matrix.os }}" + runs-on: ${{ matrix.os }} strategy: matrix: os: - "ubuntu-latest" - "macos-latest" + - [ self-hosted linux arm64 ] + - [ self-hosted linux x86 ] # TODO: test with different flox versions #flox-version: # - stable @@ -93,13 +95,15 @@ jobs: test-all-action: name: "All - Github Action Test" - runs-on: "${{ matrix.os }}" + runs-on: ${{ matrix.os }} strategy: matrix: os: - "ubuntu-latest" - "macos-latest" + - [ self-hosted linux arm64 ] + - [ self-hosted linux x86 ] # TODO: test with different flox versions #flox-version: # - stable From 12719ca036ab0072b04002d9068a099cd3c5a5bb Mon Sep 17 00:00:00 2001 From: Rok Garbas Date: Wed, 15 Nov 2023 12:20:36 +0100 Subject: [PATCH 3/7] Use correct case for self hosted runners labels --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b4ba0a8..109f583 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,8 +24,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted linux arm64 ] - - [ self-hosted linux x86 ] + - [ self-hosted Linux ARM64 ] + - [ self-hosted Linux X86 ] steps: - name: "Checkout" @@ -68,8 +68,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted linux arm64 ] - - [ self-hosted linux x86 ] + - [ self-hosted Linux ARM64 ] + - [ self-hosted Linux X86 ] # TODO: test with different flox versions #flox-version: # - stable @@ -102,8 +102,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted linux arm64 ] - - [ self-hosted linux x86 ] + - [ self-hosted Linux ARM64 ] + - [ self-hosted Linux X86 ] # TODO: test with different flox versions #flox-version: # - stable From b2d04c8c6af7a15b612d15b0925a75c10274e5d8 Mon Sep 17 00:00:00 2001 From: Rok Garbas Date: Wed, 15 Nov 2023 12:33:17 +0100 Subject: [PATCH 4/7] exactly this is the reason why we have to quote strings :) --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 109f583..8af0557 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,8 +24,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted Linux ARM64 ] - - [ self-hosted Linux X86 ] + - [ "self-hosted", "Linux", "ARM64" ] + - [ "self-hosted", "Linux", "X86" ] steps: - name: "Checkout" @@ -68,8 +68,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted Linux ARM64 ] - - [ self-hosted Linux X86 ] + - [ "self-hosted", "Linux", "ARM64" ] + - [ "self-hosted", "Linux", "X86" ] # TODO: test with different flox versions #flox-version: # - stable @@ -102,8 +102,8 @@ jobs: os: - "ubuntu-latest" - "macos-latest" - - [ self-hosted Linux ARM64 ] - - [ self-hosted Linux X86 ] + - [ "self-hosted", "Linux", "ARM64" ] + - [ "self-hosted", "Linux", "X86" ] # TODO: test with different flox versions #flox-version: # - stable From c43254ea6bf8d83a9a664b9779eace6519acb9c9 Mon Sep 17 00:00:00 2001 From: Tom Bereknyei Date: Wed, 15 Nov 2023 11:18:35 -0500 Subject: [PATCH 5/7] ci: update node version used by actions/cache --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8af0557..0659383 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,6 +37,8 @@ jobs: - name: "Cache Dependencies" id: cache uses: actions/cache@v3 + env: + GITHUB_ACTIONS_RUNNER_FORCED_NODE_VERSION: node20 with: key: npm-${{ matrix.os }}-${{ hashFiles('package-lock.json') }} path: ./node_modules From 1acbc368dbd7f99d9ffd0be2b821834e3dbcc51e Mon Sep 17 00:00:00 2001 From: Tom Bereknyei Date: Wed, 15 Nov 2023 12:07:58 -0500 Subject: [PATCH 6/7] feat: bump actions/cache to specific SHA to test --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0659383..b5e5cbc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,7 +36,7 @@ jobs: - name: "Cache Dependencies" id: cache - uses: actions/cache@v3 + uses: actions/cache@8070854e57d983bdd2887b0a708ad985f77398ab env: GITHUB_ACTIONS_RUNNER_FORCED_NODE_VERSION: node20 with: From 5317db5876a7bb8b9ddda1a61763bbd386b9365c Mon Sep 17 00:00:00 2001 From: Tom Bereknyei Date: Wed, 15 Nov 2023 15:55:20 -0500 Subject: [PATCH 7/7] ci: use X64 tag --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b5e5cbc..7cdc108 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,7 +25,7 @@ jobs: - "ubuntu-latest" - "macos-latest" - [ "self-hosted", "Linux", "ARM64" ] - - [ "self-hosted", "Linux", "X86" ] + - [ "self-hosted", "Linux", "X64" ] steps: - name: "Checkout" @@ -71,7 +71,7 @@ jobs: - "ubuntu-latest" - "macos-latest" - [ "self-hosted", "Linux", "ARM64" ] - - [ "self-hosted", "Linux", "X86" ] + - [ "self-hosted", "Linux", "X64" ] # TODO: test with different flox versions #flox-version: # - stable @@ -105,7 +105,7 @@ jobs: - "ubuntu-latest" - "macos-latest" - [ "self-hosted", "Linux", "ARM64" ] - - [ "self-hosted", "Linux", "X86" ] + - [ "self-hosted", "Linux", "X64" ] # TODO: test with different flox versions #flox-version: # - stable