Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill OpenGL 1.x support? #7

Open
kintel opened this issue Apr 4, 2023 · 2 comments · May be fixed by #9
Open

Kill OpenGL 1.x support? #7

kintel opened this issue Apr 4, 2023 · 2 comments · May be fixed by #9

Comments

@kintel
Copy link
Contributor

kintel commented Apr 4, 2023

OpenCSG has a bunch of code for supporting OpenGL 1.x (e.g. texture rectangle and non-power-of-two textures).
Is this still needed by anyone, or could we rip out the 1.x support and require OpenGL 2.x+ ?

FYI: OpenSCAD recently deprecated OpenGL 1.x support (openscad/openscad#4550)

@kintel kintel linked a pull request Jul 2, 2023 that will close this issue
@floriankirsch
Copy link
Owner

floriankirsch commented Aug 28, 2023

Removing PBuffers just seems right. It is very unlikely that some useful hardware would still provide PBuffers, but not frame buffer objects.

At the same time the (anyway unused) code that uses the WGL buffer region extension to save and restore the stencil buffer should be also removed. This should remove all code in OpenCSG that somehow depends directly on GLX or WGL. Note that In the present patch, that buffer region code currently does not compile - and also not the example application.

With the remaining extensions, I am not so convinced. Is there really a benefit? Probably for the texture rectangle path, which is not so well encapsulated in the code. Or - generally, if one could get rid of all extension checks (i.e., remove the dependency on GLEW if possible).

I think I will split your patch into different parts, devoted each to a particular extension, and reconsider.

@kintel
Copy link
Contributor Author

kintel commented Aug 28, 2023

Let me know if I can assist in splitting up my PR. It is, admittedly a pretty crude PR, mostly since I wanted some feedback before putting more effort into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants