Skip to content

A more complex check for boundary plus and minus #2635

@AkbarZafar

Description

@AkbarZafar

Describe the bug
A clear and concise description of what the bug is.
The boundary check for when symmetry is available does an equality check which disregards any additional fields that users may have set, causing the equality check to fail even if the relevant values are the same

https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/components/simulation.py#L424

To Reproduce
Steps to reproduce the behavior:

  1. create 2 BoundaryEdge types
  2. add a name field in each BoundaryEdge object, ie. "x+" and "x-"
  3. doing an equality check on the 2 objects will fail due to the name field even if all the required values are equal

Expected behavior
A clear and concise description of what you expected to happen.
The boundary check for ax_bounds.plus and ax_bounds.minus should only compare the relevant fields and not a comparison of the entire plus and minus objects.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions