Skip to content

Commit d481c26

Browse files
fix: minor tidy3d-extras testing issues
1 parent adf38ff commit d481c26

File tree

5 files changed

+14
-26
lines changed

5 files changed

+14
-26
lines changed

.github/workflows/tidy3d-extras-python-client-tests-integration.yml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ jobs:
149149
poetry run python -c "import tidy3d; print(f'tidy3d version: {tidy3d.__version__}')"
150150
poetry run python -c "import tidy3d_extras; print(f'tidy3d-extras version: {tidy3d_extras.__version__}')"
151151
cd tests/
152-
poetry run pytest _test_tidy3d_extras_license.py
152+
poetry run pytest _test_tidy3d_extras
153153
154154
- name: run-doctests
155155
run: |
@@ -164,7 +164,7 @@ jobs:
164164
export SIMCLOUD_APIKEY=${{ secrets.TIDY3D_API_KEY }}
165165
poetry run tidy3d configure --apikey ${{ secrets.TIDY3D_API_KEY }}
166166
poetry run pytest --cov=tidy3d -rF --tb=short tests/_test_data/_test_datasets_no_vtk.py
167-
poetry run pytest --cov=tidy3d -rF --tb=short --ignore=tests/_test_tidy3d_extras_license.py tests
167+
poetry run pytest --cov=tidy3d -rF --tb=short tests
168168
poetry run coverage report -m
169169
TOTAL_COVERAGE=$(poetry run coverage report --format=total)
170170
echo "total=$TOTAL_COVERAGE" >> "$GITHUB_ENV"
@@ -182,25 +182,13 @@ jobs:
182182
strategy:
183183
fail-fast: false
184184
matrix:
185-
include:
185+
include: # TODO finish container setup with Casey
186186
- name: linux-x86_64-3.10
187187
runs-on: ubuntu-latest
188188
python-version: '3.10'
189189
- name: linux-x86_64-3.13
190190
runs-on: ubuntu-latest
191191
python-version: '3.13'
192-
- name: linux-aarch64-3.10
193-
runs-on: linux-arm64
194-
python-version: '3.10'
195-
- name: linux-aarch64-3.13
196-
runs-on: linux-arm64
197-
python-version: '3.13'
198-
- name: macos-x86_64-3.10
199-
runs-on: macos-15-intel
200-
python-version: '3.10'
201-
- name: macos-x86_64-3.13
202-
runs-on: macos-15-intel
203-
python-version: '3.13'
204192
- name: macos-arm64-3.10
205193
runs-on: macos-latest
206194
python-version: '3.10'
@@ -213,7 +201,6 @@ jobs:
213201
- name: windows-x64-3.13
214202
runs-on: windows-latest
215203
python-version: '3.13'
216-
217204
defaults:
218205
run:
219206
shell: bash
@@ -299,7 +286,7 @@ jobs:
299286
poetry run python -c "import tidy3d; print(f'tidy3d version: {tidy3d.__version__}')"
300287
poetry run python -c "import tidy3d_extras; print(f'tidy3d-extras version: {tidy3d_extras.__version__}')"
301288
cd tests/
302-
poetry run pytest _test_tidy3d_extras_license.py
289+
poetry run pytest _test_tidy3d_extras
303290
304291
- name: run-doctests
305292
run: |
@@ -314,7 +301,7 @@ jobs:
314301
export SIMCLOUD_APIKEY=${{ secrets.TIDY3D_API_KEY }}
315302
poetry run tidy3d configure --apikey ${{ secrets.TIDY3D_API_KEY }}
316303
poetry run pytest --cov=tidy3d -rF --tb=short tests/_test_data/_test_datasets_no_vtk.py
317-
poetry run pytest --cov=tidy3d -rF --tb=short --ignore=tests/_test_tidy3d_extras_license.py tests
304+
poetry run pytest --cov=tidy3d -rF --tb=short tests
318305
poetry run coverage report -m
319306
TOTAL_COVERAGE=$(poetry run coverage report --format=total)
320307
echo "total=$TOTAL_COVERAGE" >> "$GITHUB_ENV"

.github/workflows/tidy3d-python-client-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ jobs:
637637
run: |
638638
source ${GITHUB_WORKSPACE}/.venv/bin/activate
639639
# pytest --cov=tidy3d -rF --tb=short tests/_test_data/_test_datasets_no_vtk.py
640-
pytest --cov=tidy3d -rF --tb=short --ignore=tests/_test_tidy3d_extras_license.py tests
640+
pytest --cov=tidy3d -rF --tb=short tests
641641
coverage report -m
642642
coverage xml -o ${GITHUB_WORKSPACE}/coverage.xml
643643
TOTAL_COVERAGE=$(coverage report --format=total)
@@ -775,7 +775,7 @@ jobs:
775775
PYTHONUNBUFFERED: "1"
776776
run: |
777777
poetry run pytest --cov=tidy3d -rF --tb=short tests/_test_data/_test_datasets_no_vtk.py
778-
poetry run pytest --cov=tidy3d -rF --tb=short --ignore=tests/_test_tidy3d_extras_license.py tests
778+
poetry run pytest --cov=tidy3d -rF --tb=short tests
779779
poetry run coverage report -m
780780
TOTAL_COVERAGE=$(poetry run coverage report --format=total)
781781
echo "total=$TOTAL_COVERAGE" >> "$GITHUB_ENV"

poetry.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ norecursedirs = [
320320
"tests/test_cli",
321321
"tests/_test_data",
322322
"tests/_test_notebooks",
323+
"tests/_test_tidy3d_extras",
323324
"tidy3d/web",
324325
"docs/notebooks",
325326
"docs/faq",
File renamed without changes.

0 commit comments

Comments
 (0)