test autograd

Author: marcorudolphflex

tests/test_components/autograd/test_autograd.py

@@ -662,7 +662,7 @@ def plot_sim(sim: td.Simulation, plot_eps: bool = True) -> None:
 # args = [("polyslab", "mode")]
 
 
-def get_functions(structure_key: str, monitor_key: str) -> typing.Callable:
+def get_functions(structure_key: str, monitor_key: str) -> dict[str, typing.Callable]:
     if structure_key == ALL_KEY:
         structure_keys = structure_keys_
     else:

tests/test_web/test_simulation_cache.py

@@ -5,9 +5,9 @@
 import pytest
 
 import tidy3d as td
+from tests.test_components.autograd.test_autograd import ALL_KEY, get_functions, params0
 from tidy3d import config
-from tidy3d.web import Job, common, run_async, download
-from tidy3d.web import Job, run_async
+from tidy3d.web import Job, common, run_async
 from tidy3d.web.api import webapi as web
 from tidy3d.web.api.container import WebContainer
 from tidy3d.web.cache import (
@@ -96,7 +96,7 @@ def _extract_simulation(kwargs):
 
     def _fake_upload(**kwargs):
         counters["upload"] += 1
-        task_id = f"{MOCK_TASK_ID}{kwargs["simulation"]._hash_self()}"
+        task_id = f"{MOCK_TASK_ID}{kwargs['simulation']._hash_self()}"
         sim = _extract_simulation(kwargs)
         if sim is not None:
             TASK_TO_SIM[task_id] = sim
@@ -171,7 +171,9 @@ def _test_run_cache_hit_async(monkeypatch, basic_simulation, tmp_path):
     sim2 = basic_simulation.updated_copy(shutoff=1e-4)
     sim3 = basic_simulation.updated_copy(shutoff=1e-3)
 
-    data = run_async({"task1": basic_simulation, "task2": sim2}, use_cache=True, path_dir=str(tmp_path))
+    data = run_async(
+        {"task1": basic_simulation, "task2": sim2}, use_cache=True, path_dir=str(tmp_path)
+    )
     data_task1 = data["task1"]  # access to store in cache
     data_task2 = data["task2"]  # access to store in cache
     assert counters["download"] == 2
@@ -186,7 +188,9 @@ def _test_run_cache_hit_async(monkeypatch, basic_simulation, tmp_path):
     assert len(cache) == 2
 
     _reset_counters(counters)
-    data = run_async({"task1": basic_simulation, "task3": sim3}, use_cache=True, path_dir=str(tmp_path))
+    data = run_async(
+        {"task1": basic_simulation, "task3": sim3}, use_cache=True, path_dir=str(tmp_path)
+    )
 
     data_task1 = data["task1"]
     data_task2 = data["task3"]  # access to store in cache
@@ -197,7 +201,7 @@ def _test_run_cache_hit_async(monkeypatch, basic_simulation, tmp_path):
     assert len(cache) == 3
 
 
-def _test_job_run_cache(monkeypatch, tmp_path_factory, basic_simulation):
+def _test_job_run_cache(monkeypatch, basic_simulation):
     counters = _patch_run_pipeline(monkeypatch)
     cache = resolve_simulation_cache(use_cache=True)
     cache.clear()
@@ -214,6 +218,27 @@ def _test_job_run_cache(monkeypatch, tmp_path_factory, basic_simulation):
     assert counters["download"] == 0
 
 
+@pytest.mark.parametrize("structure_key", ["polyslab"])
+@pytest.mark.parametrize("monitor_key", ["mode"])
+def _test_autograd_cache(monkeypatch, structure_key, monitor_key):
+    counters = _patch_run_pipeline(monkeypatch)
+    cache = resolve_simulation_cache(use_cache=True)
+    cache.clear()
+
+    functions = get_functions(ALL_KEY, "mode")
+    make_sim = functions["sim"]
+    sim = make_sim(params0)
+    web.run(sim, use_cache=True)
+    assert counters["download"] == 1
+    assert len(cache) == 1
+
+    _reset_counters(counters)
+    sim = make_sim(params0)
+    web.run(sim, use_cache=True)
+    assert counters["download"] == 0
+    assert len(cache) == 1
+
+
 def _test_load_cache_hit(monkeypatch, tmp_path, basic_simulation, fake_data):
     get_cache().clear()
     counters = _patch_run_pipeline(monkeypatch)
@@ -323,4 +348,5 @@ def test_cache_end_to_end(monkeypatch, tmp_path, tmp_path_factory, basic_simulat
     _test_cache_eviction_by_entries(monkeypatch, tmp_path_factory, basic_simulation)
     _test_cache_eviction_by_size(monkeypatch, tmp_path_factory, basic_simulation)
     _test_run_cache_hit_async(monkeypatch, basic_simulation, tmp_path)
-    _test_job_run_cache(monkeypatch, tmp_path_factory, basic_simulation)
+    _test_job_run_cache(monkeypatch, basic_simulation)
+    _test_autograd_cache(monkeypatch, basic_simulation)

tidy3d/web/api/container.py

@@ -18,15 +18,11 @@
 
 from tidy3d.components.base import Tidy3dBaseModel, cached_property
 from tidy3d.components.mode.mode_solver import ModeSolver
-from tidy3d.components.mode.simulation import ModeSimulation
 from tidy3d.components.types import annotate_type
 from tidy3d.components.types.workflow import WorkflowDataType, WorkflowType
 from tidy3d.exceptions import DataError
 from tidy3d.log import get_logging_console, log
 from tidy3d.web.api import webapi as web
-from tidy3d.web.api.tidy3d_stub import Tidy3dStub, Tidy3dStubData
-from tidy3d.web.api.webapi import _get_simulation_data_from_cache_entry, get_reduced_simulation
-from tidy3d.web.cache import TMP_BATCH_PREFIX, CacheEntry, resolve_simulation_cache
 from tidy3d.web.api.tidy3d_stub import Tidy3dStub
 from tidy3d.web.api.webapi import (
     restore_simulation_if_cached,