add tests

ndonkoHenri · ndonkoHenri · commit eced52216b9a · 2025-10-26T22:13:58.000+01:00
diff --git a/sdk/python/packages/flet/integration_tests/controls/core/test_icon.py b/sdk/python/packages/flet/integration_tests/controls/core/test_icon.py
@@ -138,7 +138,6 @@ async def test_theme(flet_app: ftt.FletTestApp):
         ),
     )
     flet_app.page.add(scr_1)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/core/test_pagelet.py b/sdk/python/packages/flet/integration_tests/controls/core/test_pagelet.py
@@ -19,7 +19,6 @@
 #             ft.Container(bgcolor=ft.Colors.AMBER, content=ft.Text("Pagelet Content"))
 #         ),
 #     )
-#     flet_app.page.update()
 #     await flet_app.tester.pump_and_settle()
 
 #     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/cupertino/golden/macos/cupertino_sliding_segmented_button/cupertino_sliding_segmented_button_basic.png b/sdk/python/packages/flet/integration_tests/controls/cupertino/golden/macos/cupertino_sliding_segmented_button/cupertino_sliding_segmented_button_basic.png
diff --git a/sdk/python/packages/flet/integration_tests/controls/cupertino/test_cupertino_context_menu.py b/sdk/python/packages/flet/integration_tests/controls/cupertino/test_cupertino_context_menu.py
@@ -34,7 +34,6 @@ async def test_cupertino_context_menu_basic(flet_app: ftt.FletTestApp, request):
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
     flet_app.page.add(ccm)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/cupertino/test_cupertino_sliding_segmented_button.py b/sdk/python/packages/flet/integration_tests/controls/cupertino/test_cupertino_sliding_segmented_button.py
@@ -5,9 +5,7 @@
 
 
 @pytest.mark.asyncio(loop_scope="module")
-async def test_cupertino_sliding_segmented_button_basic(
-    flet_app: ftt.FletTestApp, request
-):
+async def test_basic(flet_app: ftt.FletTestApp, request):
     await flet_app.assert_control_screenshot(
         request.node.name,
         ft.CupertinoSlidingSegmentedButton(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/basic.png b/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/basic.png
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/collapsed.png b/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/collapsed.png
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/expanded.png b/sdk/python/packages/flet/integration_tests/controls/material/golden/macos/expansion_tile/expanded.png
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_banner.py b/sdk/python/packages/flet/integration_tests/controls/material/test_banner.py
@@ -19,9 +19,6 @@ def handle_banner_close(e: ft.Event[ft.TextButton]):
         flet_app.page.pop_dialog()
         flet_app.page.add(ft.Text(f"Action clicked: {e.control.content}"))
 
-    eb = ft.Button(
-        "Show Banner", on_click=lambda e: flet_app.page.show_dialog(banner), key="eb"
-    )
     banner = ft.Banner(
         key="banner",
         bgcolor=ft.Colors.AMBER_100,
@@ -49,8 +46,13 @@ def handle_banner_close(e: ft.Event[ft.TextButton]):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [eb]
-    flet_app.page.update()
+    flet_app.page.add(
+        ft.Button(
+            key="eb",
+            content="Show Banner",
+            on_click=lambda e: flet_app.page.show_dialog(banner),
+        )
+    )
     await flet_app.tester.pump_and_settle()
 
     await flet_app.tester.tap(await flet_app.tester.find_by_key("eb"))
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_checkbox.py b/sdk/python/packages/flet/integration_tests/controls/material/test_checkbox.py
@@ -39,7 +39,6 @@ async def test_theme(flet_app: ftt.FletTestApp):
 
     scr_1 = ft.Screenshot(cb := ft.Checkbox(key="cb", value=True, margin=20))
     flet_app.page.add(scr_1)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_chip.py b/sdk/python/packages/flet/integration_tests/controls/material/test_chip.py
@@ -27,7 +27,6 @@ def handle_chip_click(e: ft.Event[ft.Chip]):
         e.control.label.value = "Saved to favorites"
         e.control.leading = ft.Icon(ft.Icons.FAVORITE_OUTLINED)
         e.control.disabled = True
-        flet_app.page.update()
 
     chip = ft.Chip(
         label=ft.Text("Save to favourites"),
@@ -43,7 +42,6 @@ def handle_chip_click(e: ft.Event[ft.Chip]):
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
     flet_app.page.add(chip)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
     await flet_app.tester.tap(await flet_app.tester.find_by_key("chip"))
     await flet_app.tester.pump_and_settle()
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_data_table.py b/sdk/python/packages/flet/integration_tests/controls/material/test_data_table.py
@@ -98,7 +98,6 @@ async def test_theme(flet_app: ftt.FletTestApp):
         )
     )
     flet_app.page.add(scr_1)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_dropdown.py b/sdk/python/packages/flet/integration_tests/controls/material/test_dropdown.py
@@ -28,8 +28,7 @@ async def test_basic(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [dd]
-    flet_app.page.update()
+    flet_app.page.add(dd)
     await flet_app.tester.pump_and_settle()
 
     # normal state
@@ -77,8 +76,7 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
 
-    flet_app.page.controls = [dd]
-    flet_app.page.update()
+    flet_app.page.add(dd)
     await flet_app.tester.pump_and_settle()
 
     # normal state
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_expansion_tile.py b/sdk/python/packages/flet/integration_tests/controls/material/test_expansion_tile.py
@@ -13,49 +13,55 @@ def flet_app(flet_app_function):
 
 @pytest.mark.asyncio(loop_scope="function")
 async def test_basic(flet_app: ftt.FletTestApp, request):
+    flet_app.page.window.width = 400
+    flet_app.page.window.height = 600
     await flet_app.assert_control_screenshot(
-        request.node.name, ft.ExpansionTile("ExpansionTile Title")
+        request.node.name,
+        ft.ExpansionTile(
+            title="ExpansionTile Title",
+            subtitle="ExpansionTile Subtitle",
+        ),
     )
 
 
 @pytest.mark.asyncio(loop_scope="function")
 async def test_expanded(flet_app: ftt.FletTestApp, request):
-    et = ft.ExpansionTile(
-        key="et",
-        title="ExpansionTile Title",
-        subtitle="ExpansionTile Subtitle",
-        # leading=ft.Icons.UMBRELLA,
-        trailing=ft.Icons.SUNNY,
-        controls=[
-            ft.Text("ExpansionTile Content"),
-            ft.Text("More Content"),
-        ],
-        controls_padding=ft.Padding.all(10),
-        tile_padding=ft.Padding.all(20),
-        affinity=ft.TileAffinity.LEADING,
-    )
-
-    flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [et]
-    flet_app.page.update()
+    flet_app.page.add(
+        tile := ft.ExpansionTile(
+            key="tile",
+            expanded=False,
+            title="ExpansionTile Title",
+            subtitle="ExpansionTile Subtitle",
+            trailing=ft.Icons.SUNNY,
+            controls_padding=ft.Padding.all(10),
+            tile_padding=ft.Padding.all(20),
+            affinity=ft.TileAffinity.LEADING,
+            controls=[
+                ft.Text("ExpansionTile Content"),
+                ft.Text("More Content"),
+            ],
+        )
+    )
     await flet_app.tester.pump_and_settle()
 
-    # normal state
-    flet_app.assert_screenshot(
-        "collapsed",
-        await flet_app.page.take_screenshot(
-            pixel_ratio=flet_app.screenshots_pixel_ratio
-        ),
-    )
+    # collapsed state
+    assert tile.expanded is False
+    await flet_app.assert_control_screenshot("collapsed", tile)
 
-    # open state
-    await flet_app.tester.tap(await flet_app.tester.find_by_key("et"))
+    # tap/click on the tile to expand
+    await flet_app.tester.tap(await flet_app.tester.find_by_key("tile"))
     await flet_app.tester.pump_and_settle()
-    flet_app.assert_screenshot(
-        "expanded",
-        await flet_app.page.take_screenshot(
-            pixel_ratio=flet_app.screenshots_pixel_ratio
-        ),
-    )
+
+    # expanded state
+    assert tile.expanded is True
+    await flet_app.assert_control_screenshot("expanded", tile)
+
+    # collapse programatically
+    tile.expanded = False
+    flet_app.page.update()
+    await flet_app.tester.pump_and_settle()
+
+    # collapsed state
+    await flet_app.assert_control_screenshot("collapsed", tile)
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_floating_action_button.py b/sdk/python/packages/flet/integration_tests/controls/material/test_floating_action_button.py
@@ -60,7 +60,6 @@ async def test_properties2(flet_app: ftt.FletTestApp, request):
         mouse_cursor=ft.MouseCursor.COPY,  # is not shown on screenshots
     )
     flet_app.page.add(fab)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_list_tile.py b/sdk/python/packages/flet/integration_tests/controls/material/test_list_tile.py
@@ -241,7 +241,6 @@ async def test_toggle_inputs(flet_app: ftt.FletTestApp, request):
     )
 
     flet_app.page.add(lt)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_menu_bar.py b/sdk/python/packages/flet/integration_tests/controls/material/test_menu_bar.py
@@ -41,8 +41,7 @@ async def test_menu_bar_basic(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [pb]
-    flet_app.page.update()
+    flet_app.page.add(pb)
     await flet_app.tester.pump_and_settle()
 
     # normal state
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_navigation_bar.py b/sdk/python/packages/flet/integration_tests/controls/material/test_navigation_bar.py
@@ -68,7 +68,6 @@ async def test_theme(flet_app: ftt.FletTestApp):
         )
     )
     flet_app.page.add(scr_1)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_popup_menu_button.py b/sdk/python/packages/flet/integration_tests/controls/material/test_popup_menu_button.py
@@ -36,8 +36,7 @@ async def test_basic(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [pb]
-    flet_app.page.update()
+    flet_app.page.add(pb)
     await flet_app.tester.pump_and_settle()
 
     # normal state
@@ -105,8 +104,7 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [pb]
-    flet_app.page.update()
+    flet_app.page.add(pb)
     await flet_app.tester.pump_and_settle()
 
     # normal state
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_range_slider.py b/sdk/python/packages/flet/integration_tests/controls/material/test_range_slider.py
@@ -23,8 +23,7 @@ async def test_range_slider(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [c]
-    flet_app.page.update()
+    flet_app.page.add(c)
     await flet_app.tester.pump_and_settle()
 
     # default
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_search_bar.py b/sdk/python/packages/flet/integration_tests/controls/material/test_search_bar.py
@@ -27,8 +27,7 @@ async def handle_tap(e: ft.Event[ft.SearchBar]):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [sb]
-    flet_app.page.update()
+    flet_app.page.add(sb)
     await flet_app.tester.pump_and_settle()
 
     # normal state
@@ -102,8 +101,7 @@ async def handle_tap(e: ft.Event[ft.SearchBar]):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [sb]
-    flet_app.page.update()
+    flet_app.page.add(sb)
     await flet_app.tester.pump_and_settle()
 
     # normal state
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_segmented_button.py b/sdk/python/packages/flet/integration_tests/controls/material/test_segmented_button.py
@@ -82,7 +82,6 @@ async def test_theme(flet_app: ftt.FletTestApp):
         key="sb",
     )
     flet_app.page.add(scr_1)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/material/test_vertical_divider.py b/sdk/python/packages/flet/integration_tests/controls/material/test_vertical_divider.py
@@ -17,7 +17,6 @@ async def test_vertical_divider_basic(flet_app: ftt.FletTestApp, request):
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
     flet_app.page.add(ft.VerticalDivider(expand=True))
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
@@ -45,7 +44,6 @@ async def test_vertical_divider_properties(flet_app: ftt.FletTestApp, request):
             radius=10,
         )
     )
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/integration_tests/controls/theme/test_expansion_tile_theme.py b/sdk/python/packages/flet/integration_tests/controls/theme/test_expansion_tile_theme.py
@@ -46,8 +46,7 @@ async def test_expansion_tile_theme(flet_app: ftt.FletTestApp, request):
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
-    flet_app.page.controls = [et]
-    flet_app.page.update()
+    flet_app.page.add(et)
     await flet_app.tester.pump_and_settle()
 
     # normal state
diff --git a/sdk/python/packages/flet/integration_tests/controls/theme/test_floating_action_button_theme.py b/sdk/python/packages/flet/integration_tests/controls/theme/test_floating_action_button_theme.py
@@ -60,7 +60,6 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
     fab3 = ft.FloatingActionButton("Text", disabled=True)
     fab4 = ft.FloatingActionButton("Long Long Long Long Text", disabled=True)
     flet_app.page.add(fab1, fab2, fab3, fab4)
-    flet_app.page.update()
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
@@ -84,8 +83,6 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
     )
 
     # test hover
-    flet_app.page.update()
-    await flet_app.tester.pump_and_settle()
     button = await flet_app.tester.find_by_key("fab1")
     assert button.count == 1
     await flet_app.tester.mouse_hover(button)
diff --git a/sdk/python/packages/flet/integration_tests/controls/theme/test_list_tile_theme.py b/sdk/python/packages/flet/integration_tests/controls/theme/test_list_tile_theme.py
@@ -45,14 +45,16 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
             ),
             mouse_cursor=ft.MouseCursor.FORBIDDEN,
             min_height=100,
+            style=ft.ListTileStyle.LIST,
+            title_alignment=ft.ListTileTitleAlignment.THREE_LINE,
         )
     )
 
     flet_app.page.enable_screenshots = True
     flet_app.page.window.width = 400
     flet_app.page.window.height = 600
 
-    lt1 = ft.ListTile(
+    tile_1 = ft.ListTile(
         "ListTile with is_three_line = False",
         subtitle="List",
         leading=ft.Icon(ft.Icons.STAR),
@@ -63,7 +65,7 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
         toggle_inputs=True,
         visual_density=ft.VisualDensity.COMPACT,
     )
-    lt2 = ft.ListTile(
+    tile_2 = ft.ListTile(
         "ListTile default is_three_line",
         subtitle="List",
         leading=ft.Icon(ft.Icons.STAR),
@@ -74,7 +76,7 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
         style=ft.ListTileStyle.LIST,
         toggle_inputs=False,
     )
-    lt3 = ft.ListTile(
+    tile_3 = ft.ListTile(
         title="ListTile is_three_line = True",
         subtitle="Subtitle",
         is_three_line=True,
@@ -86,8 +88,7 @@ async def test_theme(flet_app: ftt.FletTestApp, request):
         shape=ft.RoundedRectangleBorder(radius=10),
     )
 
-    flet_app.page.add(lt1, lt2, lt3)
-    flet_app.page.update()
+    flet_app.page.add(tile_1, tile_2, tile_3)
     await flet_app.tester.pump_and_settle()
 
     flet_app.assert_screenshot(
diff --git a/sdk/python/packages/flet/src/flet/controls/theme.py b/sdk/python/packages/flet/src/flet/controls/theme.py

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,6 @@ async def test_theme(flet_app: ftt.FletTestApp):`
`138`	`138`	`),`
`139`	`139`	`)`
`140`	`140`	`flet_app.page.add(scr_1)`
`141`		`- flet_app.page.update()`
`142`	`141`	`await flet_app.tester.pump_and_settle()`
`143`	`142`
`144`	`143`	`flet_app.assert_screenshot(`