Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip routing on a particular setRoute() call. #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyburke
Copy link
Contributor

I'm submitting this pull request even though I'm not sure it's the proper solution. I'd like to be able to set the route without triggering routing in a specific case. I don't see any better way to accomplish that, but I'm open to suggestions on how this code could be improved.

As it stands, this code is fulfilling my need. I can do:

setRoute( someRoute, true );

and routing will not fire for that particular setRoute() call.

Please let me know what you think of this change.

@andyburke
Copy link
Contributor Author

Any word on this? Is there something that doesn't meet your requirements for this patch? I'm willing to work with you on modifications.

@captn3m0
Copy link

👍 to this.

@ranadeep47
Copy link

+1

1 similar comment
@iby
Copy link

iby commented Feb 24, 2014

+1

@adammiller
Copy link

+1. Surprised this isn't already supported.

@bvandorn
Copy link

+1: I can see a less intrusive option being to call a skipNextRoute() method as a less intrusive alternative

@ingro
Copy link

ingro commented Feb 21, 2015

That would be very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants