Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always disconnects #33

Closed
bilelmoussaoui opened this issue Nov 25, 2024 · 8 comments · Fixed by #36
Closed

Always disconnects #33

bilelmoussaoui opened this issue Nov 25, 2024 · 8 comments · Fixed by #36

Comments

@bilelmoussaoui
Copy link
Member

When using the app, if I close it, the app seems to require me to re-login again even if I select to use a pin to unlock it.

It seems like the app is using the portal backend of libsecret given the result i see using https://flathub.org/apps/app.drey.KeyRack

Is Electron/Chromium is supposed to work fine with the libsecret portal backend? if not, maybe libsecret should not be used from the submodule and instead embedded in the manifest so we can disable gcrypt (iirc) which would disable portal usage as you seem to also give it access to the whole org.freedestkop.secrets anyways.

The current status quo is not optimal and makes the app annoying to use

@proletarius101
Copy link
Collaborator

Adding the permission was a mistake. It seems that it remembers the login status and asks me for the password only, when I exit the application and start it again, with --no-talk-name=org.freedesktop.secrets. Can you try flatpak run --no-talk-name=org.freedesktop.secrets me.proton.Pass?

proletarius101 added a commit that referenced this issue Nov 25, 2024
According to #33 (comment), with the submodules libsecret, it should use the portal instead.
@proletarius101
Copy link
Collaborator

@bilelmoussaoui
Copy link
Member Author

Might be relevant? https://github.com/flathub/com.vscodium.codium/pull/389/files

that is exactly what I mentioned above ;) build libsecret without the portal support until chromium fixes itslef

@proletarius101
Copy link
Collaborator

proletarius101 commented Nov 26, 2024

@bilelmoussaoui They proposed the other way around - disabling the file-based backend and only using the DBus based backend.

It seems that Chromium-based applications will only work with the DBus-based backend: flathub/shared-modules#294 (comment)

@bilelmoussaoui
Copy link
Member Author

No, they proposed exactly what i said above. The file backend is the portal one :)

@proletarius101
Copy link
Collaborator

No, they proposed exactly what i said above. The file backend is the portal one :)

Thanks for the explanation. Then that's what I will do

@proletarius101
Copy link
Collaborator

@bilelmoussaoui Can you have a try? #36 (comment)

@bilelmoussaoui
Copy link
Member Author

can confirm the issue is now fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants