Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal server error on /request-review API #3911

Open
xytovl opened this issue Sep 26, 2024 · 7 comments
Open

Internal server error on /request-review API #3911

xytovl opened this issue Sep 26, 2024 · 7 comments

Comments

@xytovl
Copy link

xytovl commented Sep 26, 2024

I want to request a review for io.github.wivrn.wivrn.

Developer portal doesn't show pending reviews for the app.

From https://flathub.org/apps/io.github.wivrn.wivrn web page when logged in, I click "Request review" and nothing happens on web UI.

Looking at inspector, I can see a request is done for https://flathub.org/api/v2/quality-moderation/io.github.wivrn.wivrn/request-review and fails with code 500, "Internal Server Error" and no further details.

I tried multiple times and consistently have the same error.
Last attempt an 2024-09-26 16:43:37 UTC.

@razzeee
Copy link
Member

razzeee commented Sep 27, 2024

The server errors, as it already has a review requested from your app. I'm curious, why you still had the UI to request one though.

@xytovl
Copy link
Author

xytovl commented Sep 27, 2024

In developer portal, request https://flathub.org/api/v2/moderation/apps/io.github.wivrn.wivrn?include_handled=true&include_outdated=true&limit=10&offset=0 returns

{
    "requests": [],
    "requests_count": 0
}

Maybe the issue is related to users, I am co-author of the app, @Meumeu did the initial submission, but he has the same result in developer portal and request review.

@razzeee
Copy link
Member

razzeee commented Sep 27, 2024

It should be controlled by the https://flathub.org/api/v2/quality-moderation/io.github.wivrn.wivrn/status

I'm not sure, if you requested a review and it was already done/dismissed and thus doesn't show anything anymore.

@xytovl
Copy link
Author

xytovl commented Sep 27, 2024

status API returns

{
    "passes": false,
    "unrated": 0,
    "passed": 0,
    "not_passed": 0,
    "last_updated": "2024-09-27T11:58:48.582189",
    "review_requested_at": null
}

web page shows
Capture d’écran du 2024-09-27 14-02-22

@razzeee
Copy link
Member

razzeee commented Sep 27, 2024

seems correct, did you try to request a review again?

@xytovl
Copy link
Author

xytovl commented Sep 27, 2024

Still get an error (request at 2024-09-27 13:31:49 UTC)

@razzeee
Copy link
Member

razzeee commented Sep 27, 2024

okay, the app never has had a review and isn't listed in the search, as it does not have screenshots so both might cause this problem. I think we only allow reviews for "frontend apps" right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants