Skip to content

Commit 3c604e9

Browse files
AaronBallmanAaronBallman
committed
Update the clang and clang-tools-extra code owners files
This also converts the Clang code owners file from a flat text file to an RST file that is linked in to the rest of our documentation. The RFC for this can be found at: https://discourse.llvm.org/t/rfc-proposed-changes-to-clangs-code-ownership/ Differential Revision: https://reviews.llvm.org/D132550
1 parent a8fcb51 commit 3c604e9

File tree

5 files changed

+270
-77
lines changed

5 files changed

+270
-77
lines changed

Diff for: ‎clang-tools-extra/CODE_OWNERS.TXT

+12-11
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,27 @@ also the gatekeepers for their part of Clang, with the final word on what goes
44
in or not.
55

66
The list is sorted by surname and formatted to allow easy grepping and
7-
beautification by scripts. The fields are: name (N), email (E), web-address
8-
(W), PGP key ID and fingerprint (P), description (D), and snail-mail address
9-
(S).
7+
beautification by scripts. The fields are: name (N), email (E), Phabricator
8+
handle (H), and description (D).
109

1110
N: Aaron Ballman
1211
E: [email protected]
12+
H: aaron.ballman
1313
D: clang-query
1414

15-
N: Manuel Klimek
16-
E: [email protected]
17-
D: clang-rename, all parts of clang-tools-extra not covered by someone else
18-
19-
N: Alexander Kornienko
20-
E: [email protected]
21-
D: clang-tidy
22-
2315
N: Julie Hockett
2416
E: [email protected]
2517
D: clang-doc
2618

19+
N: Nathan James
20+
E: [email protected]
21+
H: njames93
22+
D: clang-tidy
23+
24+
N: Manuel Klimek
25+
E: [email protected]
26+
D: clang-rename, all parts of clang-tools-extra not covered by someone else
27+
2728
N: Sam McCall
2829
E: [email protected]
2930
D: clangd

Diff for: ‎clang/CODE_OWNERS.TXT

-66
This file was deleted.

Diff for: ‎clang/CodeOwners.rst

+256
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,256 @@
1+
=================
2+
Clang Code Owners
3+
=================
4+
5+
This file is a list of the people responsible for ensuring that patches for a
6+
particular part of Clang are reviewed, either by themself or by someone else.
7+
They are also the gatekeepers for their part of Clang, with the final word on
8+
what goes in or not.
9+
10+
.. contents::
11+
:depth: 2
12+
:local:
13+
14+
Current Code Owners
15+
===================
16+
The following people are the active code owners for the project. Please reach
17+
out to them for code reviews, questions about their area of expertise, or other
18+
assistance.
19+
20+
All parts of Clang not covered by someone else
21+
----------------------------------------------
22+
| Aaron Ballman
23+
| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub)
24+
25+
26+
Contained Components
27+
--------------------
28+
These code owners are responsible for particular high-level components within
29+
Clang that are typically contained to one area of the compiler.
30+
31+
AST matchers
32+
~~~~~~~~~~~~
33+
| Manuel Klimek
34+
| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
35+
36+
37+
Clang LLVM IR generation
38+
~~~~~~~~~~~~~~~~~~~~~~~~
39+
| John McCall
40+
| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
41+
42+
| Eli Friedman
43+
| efriedma\@quicinc.com (email), efriedma (Phabricator), efriedma-quic (GitHub)
44+
45+
| Anton Korobeynikov
46+
| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
47+
48+
49+
Analysis & CFG
50+
~~~~~~~~~~~~~~
51+
| Dmitri Gribenko
52+
| gribozavr\@gmail.com (email), gribozavr (Phabricator), gribozavr (GitHub)
53+
54+
| Yitzhak Mandelbaum
55+
| yitzhakm\@google.com (email), ymandel (Phabricator), ymand (GitHub)
56+
57+
| Stanislav Gatev
58+
| sgatev\@google.com (email), sgatev (Phabricator), sgatev (GitHub)
59+
60+
61+
Modules & serialization
62+
~~~~~~~~~~~~~~~~~~~~~~~
63+
| Chuanqi Xu
64+
| yedeng.yd\@linux.alibaba.com (email), ChuanqiXu (Phabricator), ChuanqiXu9 (GitHub)
65+
66+
| Michael Spencer
67+
| bigcheesegs\@gmail.com (email), Bigcheese (Phabricator), Bigcheese (GitHub)
68+
69+
70+
Templates
71+
~~~~~~~~~
72+
| Erich Keane
73+
| erich.keane\@intel.com (email), ErichKeane (Phabricator), erichkeane (GitHub)
74+
75+
76+
Debug information
77+
~~~~~~~~~~~~~~~~~
78+
| Eric Christopher
79+
| echristo\@gmail.com (email), echristo (Phabricator), echristo (GitHub)
80+
81+
82+
Exception handling
83+
~~~~~~~~~~~~~~~~~~
84+
| Anton Korobeynikov
85+
| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
86+
87+
88+
Clang static analyzer
89+
~~~~~~~~~~~~~~~~~~~~~
90+
| Artem Dergachev
91+
| adergachev\@apple.com (email), NoQ (Phabricator), haoNoQ (GitHub)
92+
93+
| Gábor Horváth
94+
| xazax.hun\@gmail.com (email), xazax.hun (Phabricator), Xazax-hun (GitHub)
95+
96+
97+
Compiler options
98+
~~~~~~~~~~~~~~~~
99+
| Jan Svoboda
100+
| jan_svoboda\@apple.com (email), jansvoboda11 (Phabricator), jansvoboda11 (GitHub)
101+
102+
103+
OpenBSD driver
104+
~~~~~~~~~~~~~~
105+
| Brad Smith
106+
| brad\@comstyle.com (email), brad (Phabricator), brad0 (GitHub)
107+
108+
109+
Driver parts not covered by someone else
110+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
111+
| Fangrui Song
112+
| maskray\@google.com (email), MaskRay (Phabricator), MaskRay (GitHub)
113+
114+
115+
Tools
116+
-----
117+
These code owners are responsible for user-facing tools under the Clang
118+
umbrella or components used to support such tools.
119+
120+
Tooling library
121+
~~~~~~~~~~~~~~~
122+
| Manuel Klimek
123+
| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
124+
125+
126+
clang-format
127+
~~~~~~~~~~~~
128+
| MyDeveloperDay
129+
| mydeveloperday\@gmail.com (email), MyDeveloperDay (Phabricator), MyDeveloperDay (GitHub)
130+
131+
| Owen Pan
132+
| owenpiano\@gmail.com (email), owenpan (Phabricator), owenca (GitHub)
133+
134+
135+
ABIs
136+
----
137+
The following people are responsible for decisions involving ABI.
138+
139+
Itanium ABI
140+
~~~~~~~~~~~
141+
| John McCall
142+
| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
143+
144+
145+
Microsoft ABI
146+
~~~~~~~~~~~~~
147+
| Reid Kleckner
148+
| rnk\@google.com (email), rnk (Phabricator), rnk (GitHub)
149+
150+
151+
ARM EABI
152+
~~~~~~~~
153+
| Anton Korobeynikov
154+
| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
155+
156+
157+
Compiler-Wide Topics
158+
--------------------
159+
The following people are responsible for functionality that does not fit into
160+
a single part of the compiler, but instead span multiple components within the
161+
compiler.
162+
163+
Attributes
164+
~~~~~~~~~~
165+
| Erich Keane
166+
| erich.keane\@intel.com (email), ErichKeane (Phabricator), erichkeane (GitHub)
167+
168+
169+
Inline assembly
170+
~~~~~~~~~~~~~~~
171+
| Eric Christopher
172+
| echristo\@gmail.com (email), echristo (Phabricator), echristo (GitHub)
173+
174+
175+
Text encodings
176+
~~~~~~~~~~~~~~
177+
| Tom Honermann
178+
| tom\@honermann.net (email), tahonermann (Phabricator), tahonermann (GitHub)
179+
180+
| Corentin Jabot
181+
| corentin.jabot\@gmail.com (email), cor3ntin (Phabricator), cor3ntin (GitHub)
182+
183+
184+
CMake integration
185+
~~~~~~~~~~~~~~~~~
186+
| Petr Hosek
187+
| phosek\@google.com (email), phosek (Phabricator), petrhosek (GitHub)
188+
189+
| John Ericson
190+
| git\@johnericson.me (email), Ericson2314 (Phabricator), Ericson2314 (GitHub)
191+
192+
193+
General Windows support
194+
~~~~~~~~~~~~~~~~~~~~~~~
195+
| Reid Kleckner
196+
| rnk\@google.com (email), rnk (Phabricator), rnk (GitHub)
197+
198+
199+
Standards Conformance
200+
---------------------
201+
The following people are responsible for validating that changes are conforming
202+
to a relevant standard. Contact them for questions about how to interpret a
203+
standard, when fixing standards bugs, or when implementing a new standard feature.
204+
205+
C conformance
206+
~~~~~~~~~~~~~
207+
| Aaron Ballman
208+
| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub)
209+
210+
211+
C++ conformance
212+
~~~~~~~~~~~~~~~
213+
| Hubert Tong
214+
| hubert.reinterpretcast\@gmail.com (email), hubert.reinterpretcast (Phabricator), hubert-reinterpretcast (GitHub)
215+
216+
217+
Objective-C/C++ conformance
218+
~~~~~~~~~~~~~~~~~~~~~~~~~~~
219+
| John McCall
220+
| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
221+
222+
223+
OpenMP conformance
224+
~~~~~~~~~~~~~~~~~~
225+
| Alexey Bataev
226+
| a.bataev\@hotmail.com (email), ABataev (Phabricator), cilkplus (GitHub)
227+
228+
229+
OpenCL conformance
230+
~~~~~~~~~~~~~~~~~~
231+
| Anastasia Stulova
232+
| anastasia.stulova\@arm.com (email), Anastasia (Phabricator), AnastasiaStulova (GitHub)
233+
234+
235+
SYCL conformance
236+
~~~~~~~~~~~~~~~~
237+
| Alexey Bader
238+
| alexey.bader\@intel.com (email), bader (Phabricator), bader (GitHub)
239+
240+
241+
Former Code Owners
242+
==================
243+
The following people have graciously spent time performing code ownership
244+
responsibilities but are no longer active in that role. Thank you for all your
245+
help with the success of the project!
246+
247+
Emeritus owners
248+
---------------
249+
| Doug Gregor (dgregor\@apple.com)
250+
| Richard Smith (richard\@metafoo.co.uk)
251+
252+
253+
Former component owners
254+
-----------------------
255+
| Chandler Carruth (chandlerc\@gmail.com, chandlerc\@google.com) -- CMake, library layering
256+
| Devin Coughlin (dcoughlin\@apple.com) -- Clang static analyzer

Diff for: ‎clang/docs/CodeOwners.rst

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.. include:: ../CodeOwners.rst

Diff for: ‎clang/docs/index.rst

+1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ Design Documents
9898
.. toctree::
9999
:maxdepth: 1
100100

101+
CodeOwners
101102
InternalsManual
102103
DriverInternals
103104
OffloadingDesign

0 commit comments

Comments
 (0)