Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likes sends notifications for post types that have no text body #4108

Open
luceos opened this issue Nov 13, 2024 · 0 comments
Open

Likes sends notifications for post types that have no text body #4108

luceos opened this issue Nov 13, 2024 · 0 comments

Comments

@luceos
Copy link
Member

luceos commented Nov 13, 2024

Current Behavior

We received two pull requests (#4075 and #4095) where the Likes extension is modified to only send notifications for the Post type Comment. The problem seems to be that the notification cannot render the content as text for any other Post type.

Although the proposed solutions are valid solutions to this problem, we need something that is future proof and extensible.

Possible Solution

What we need to do is extend the Post type class with a property that allows us to signify whether a Post type is allowed to notify.

The benefit is that implementations of Post type can easily be adapted to this new feature, without sacrificing any flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant