Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of proprietary license in composer.json #44

Open
DavideIadeluca opened this issue Sep 23, 2024 · 2 comments
Open

Allow usage of proprietary license in composer.json #44

DavideIadeluca opened this issue Sep 23, 2024 · 2 comments

Comments

@DavideIadeluca
Copy link

With version @flarum/cli/2.0.0-beta.17 darwin-arm64 node-v20.6.0 it's currently not possible to use any other license than the official SPDX licenses, which in principle makes sense. A workaround for using the CLI is to temporarily use a different, valid SPDX license and change it back after.

When trying to use the cli anyways with an invalid SPDX license, such as proprietary, the following error is thrown:

Error occurred, and could not complete:
Cannot find module 'spdx-license-list/licenses/proprietary'

Therefore, I would propose that proprietary is added as an exception and made available to developers working on private extensions. I'm just throwing this idea out there, I have no idea if this can even feasibly be done in this repo.

Thoughts?

SychO9 added a commit that referenced this issue Sep 23, 2024
@SychO9
Copy link
Member

SychO9 commented Sep 23, 2024

pushed a commit that will fix it for the next version 👍🏼

@DavideIadeluca
Copy link
Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants