From 9d31624f5a56fa9041b4bfba25f4bcb00be23015 Mon Sep 17 00:00:00 2001 From: julian-fireblocks Date: Mon, 3 Nov 2025 14:48:43 +0800 Subject: [PATCH 1/2] Fix bug skipping account linkage --- .../tests/server-tests/collateral/account-link.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2/api-validator/tests/server-tests/collateral/account-link.test.ts b/v2/api-validator/tests/server-tests/collateral/account-link.test.ts index cb867e3a..e48990a3 100644 --- a/v2/api-validator/tests/server-tests/collateral/account-link.test.ts +++ b/v2/api-validator/tests/server-tests/collateral/account-link.test.ts @@ -26,12 +26,12 @@ describe.skipIf(noCollateralCapability)('Account Link', () => { accountId, }); - const linkedAccount: CollateralAccountLink | undefined = + const unlinkedAccount: CollateralAccountLink | undefined = getCollateralAccountLinks.collateralLinks.find( (link) => link.status !== CollateralLinkStatus.LINKED ); - if (!linkedAccount) { + if (unlinkedAccount) { const linkAccount = await client.collateral.createCollateralAccountLink({ accountId, requestBody: { From 9065b82c89b090bd3b081a20a42be5dcbb6c1c72 Mon Sep 17 00:00:00 2001 From: julian-fireblocks Date: Wed, 5 Nov 2025 10:28:56 +0800 Subject: [PATCH 2/2] Enhance account link tests with status validation Add checks for unlinked account status in tests. --- .../tests/server-tests/collateral/account-link.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/v2/api-validator/tests/server-tests/collateral/account-link.test.ts b/v2/api-validator/tests/server-tests/collateral/account-link.test.ts index e48990a3..83369106 100644 --- a/v2/api-validator/tests/server-tests/collateral/account-link.test.ts +++ b/v2/api-validator/tests/server-tests/collateral/account-link.test.ts @@ -31,6 +31,9 @@ describe.skipIf(noCollateralCapability)('Account Link', () => { (link) => link.status !== CollateralLinkStatus.LINKED ); + expect(unlinkedAccount?.status).toBeDefined(); + expect(Object.values(CollateralLinkStatus)).toContain(unlinkedAccount?.status); + if (unlinkedAccount) { const linkAccount = await client.collateral.createCollateralAccountLink({ accountId, @@ -49,7 +52,6 @@ describe.skipIf(noCollateralCapability)('Account Link', () => { expect(linkAccount.env).toBe(AccountEnvironment.PROD); } - expect(linkedAccount?.status).toBeDefined(); }); });