feat(cli/update): improve version not found error message, and throw error message when installing same version with -v (must use -r)

Author: CorieW

bin/install_cli

@@ -239,13 +239,19 @@ fi
 DOWNLOAD_URL="https://storage.googleapis.com/genkit-assets-cli/$channel/$MACHINE/latest"
 echo "-- Downloading binary from $DOWNLOAD_URL"
 
-# We use "curl" to download the binary with a flag set to follow redirects
-# (GitHub download URLs redirect to CDNs) and a flag to show a progress bar.
-curl -o "/tmp/genkit_standalone.tmp" --fail -L --progress-bar $DOWNLOAD_URL
-if [ $? -ne 0 ]; then
-    echo "Something went wrong. Failed to download binary from $DOWNLOAD_URL"
-    echo "Please file a bug with your system information on GitHub."
-    echo "https://github.com/firebase/genkit/"
+# Download the binary, but capture HTTP status code to detect 404s (package not found)
+HTTP_STATUS=$(curl -w "%{http_code}" -o "/tmp/genkit_standalone.tmp" --fail -L --progress-bar "$DOWNLOAD_URL" 2>/dev/null)
+CURL_EXIT_CODE=$?
+
+if [ $CURL_EXIT_CODE -ne 0 ] || [ "$HTTP_STATUS" = "404" ]; then
+    # Check if the user requested a specific version (by checking if DOWNLOAD_URL contains /v[0-9])
+    if [[ "$DOWNLOAD_URL" =~ /v[0-9]+\.[0-9]+\.[0-9]+/ ]] || [[ "$HTTP_STATUS" = "404" ]]; then
+        echo "Package not found. The requested version does not exist for your platform."
+    else
+        echo "Something went wrong. Failed to download binary from $DOWNLOAD_URL"
+        echo "Please file a bug with your system information on GitHub."
+        echo "https://github.com/firebase/genkit/"
+    fi
 
     send_analytics_event download_failure
 

genkit-tools/cli/src/commands/update.ts

@@ -250,6 +250,15 @@ async function downloadAndInstall(version: string): Promise<void> {
 
   // If not running from a binary, we should install using package manager
   if (!runtime.isCompiledBinary) {
+    // Check if the requested version is available on npm
+    const availableVersions = await getAvailableVersionsFromNpm();
+    if (!availableVersions.includes(version.replace(/^v/, ''))) {
+      logger.error(
+        `Version ${clc.bold(version)} is not available on npm.`
+      );
+      process.exit(1);
+    }
+
     const pm = await inquirePackageManager();
     let command = '';
 
@@ -260,7 +269,7 @@ async function downloadAndInstall(version: string): Promise<void> {
     }
 
     logger.info(`Running using ${pm?.type}, downloading using ${pm?.type}...`);
-    execSync(command);
+    execSync(command, { stdio: 'inherit' });
     logger.info(
       `${clc.green('✓')} Successfully updated to ${clc.bold(version)}`
     );
@@ -441,6 +450,13 @@ export const update = new Command('update')
 
         logger.info(`${clc.yellow('!')} Reinstalling v${clc.bold(version)}...`);
       } else if (version) {
+        if (version === currentVersion) {
+          logger.info(
+            `${clc.green('✓')} Already using version v${clc.bold(version)}.`
+          );
+          return;
+        }
+
         logger.info(`Installing v${clc.bold(version)}...`);
       } else {
         logger.info('Checking for updates...');