From 002191e8afc058101df56f118beb1d611d0f8259 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:37:54 -0400 Subject: [PATCH 01/61] spelling: access Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/utils/pendingemailcredential_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/utils/pendingemailcredential_test.js b/javascript/utils/pendingemailcredential_test.js index d0ffc3f5..de1b2736 100644 --- a/javascript/utils/pendingemailcredential_test.js +++ b/javascript/utils/pendingemailcredential_test.js @@ -54,7 +54,7 @@ function setUp() { credentialObject = { 'providerId': 'google.com', 'signInMethod': 'google.com', - 'oauthAcessToken': 'ACCESS_TOKEN' + 'oauthAccessToken': 'ACCESS_TOKEN' }; credential = { 'providerId': 'google.com', From a9c17ec99703dc6b9c3eb3f65daa242c8979fad6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:38:02 -0400 Subject: [PATCH 02/61] spelling: account Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/widgets/handler/actioncode.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/widgets/handler/actioncode.js b/javascript/widgets/handler/actioncode.js index f85e921a..db71eab2 100644 --- a/javascript/widgets/handler/actioncode.js +++ b/javascript/widgets/handler/actioncode.js @@ -372,7 +372,7 @@ firebaseui.auth.widget.handler.handleRevertSecondFactorAddition = * @param {!firebaseui.auth.AuthUI} app The current Firebase UI instance whose * configuration is used. * @param {!Element} container The container DOM element. - * @param {string} email The email of the acount. + * @param {string} email The email of the account. * @param {!firebase.auth.MultiFactorInfo} multiFactorInfo The info of * multi-factor to be unenrolled. * @private From 716b09c339aaf64e452b5ef8ed8e76b1e1c31fc0 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:38:14 -0400 Subject: [PATCH 03/61] spelling: anonymous Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- README.md | 2 +- javascript/widgets/authui_test.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index bf577643..3ee36e57 100644 --- a/README.md +++ b/README.md @@ -1547,7 +1547,7 @@ ui.start('#firebaseui-auth-container', { return app.database().ref('users/' + user.uid).set(data); }) .then(function() { - // Delete anonymnous user. + // Delete anonymous user. return anonymousUser.delete(); }).then(function() { // Clear data in case a new user signs in, and the state change diff --git a/javascript/widgets/authui_test.js b/javascript/widgets/authui_test.js index ec541c32..2d9c1ff6 100644 --- a/javascript/widgets/authui_test.js +++ b/javascript/widgets/authui_test.js @@ -2220,7 +2220,7 @@ function testUpgradeWithEmailLink_emailExists_pendingCredential_conflict() { 'isNewUser': false } }; - // Simulate anononymous user signed in for upgrade flow. + // Simulate anonymous user signed in for upgrade flow. app.getExternalAuth().setUser(anonymousUser); app.upgradeWithEmailLink( @@ -2302,7 +2302,7 @@ function testUpgradeWithEmailLink_newEmail_success() { 'isNewUser': false } }; - // Simulate anononymous user signed in for upgrade flow. + // Simulate anonymous user signed in for upgrade flow. app.getExternalAuth().setUser(anonymousUser); app.upgradeWithEmailLink(app.getExternalAuth().currentUser, email, link) @@ -2345,7 +2345,7 @@ function testUpgradeWithEmailLink_error() { app.getAuth().install(); app.getExternalAuth().install(); asyncTestCase.waitForSignals(1); - // Simulate anononymous user signed in for upgrade flow. + // Simulate anonymous user signed in for upgrade flow. app.getExternalAuth().setUser(anonymousUser); // Confirm backend error passed through to client. @@ -4095,7 +4095,7 @@ function testStartSignInAnonymously_success() { } -function testStartSignInAnonymously_upgradeAnon_isAnonmous_success() { +function testStartSignInAnonymously_upgradeAnon_isAnonymous_success() { testApp = new firebaseui.auth.testing.FakeAppClient(options); testAuth = testApp.auth(); app = new firebaseui.auth.AuthUI(testAuth, 'id0'); From cd38b0abf47811efb56f6c64193ff417066b95d6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:33:52 -0400 Subject: [PATCH 04/61] spelling: before Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/widgets/authui.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/javascript/widgets/authui.js b/javascript/widgets/authui.js index 45391c20..ca2831d0 100644 --- a/javascript/widgets/authui.js +++ b/javascript/widgets/authui.js @@ -350,7 +350,7 @@ firebaseui.auth.AuthUI.prototype.getRedirectResult = function() { })); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. this.getRedirectResult_ = this.initializeForAutoUpgrade_(cb); } @@ -1076,7 +1076,7 @@ firebaseui.auth.AuthUI.prototype.sendSignInLinkToEmail = return /** @type {!firebase.Promise} */ ( self.getAuth().sendSignInLinkToEmail(email, actionCodeSettings)); }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb).then(function() { firebaseui.auth.storage.setEmailForSignIn(sid, email, self.getAppId()); @@ -1326,7 +1326,7 @@ firebaseui.auth.AuthUI.prototype.startSignInWithEmailAndPassword = return result; } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return self.initializeForAutoUpgrade_(cb); })); @@ -1362,7 +1362,7 @@ firebaseui.auth.AuthUI.prototype.startCreateUserWithEmailAndPassword = email, password)); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb); }; @@ -1409,7 +1409,7 @@ firebaseui.auth.AuthUI.prototype.startSignInWithCredential = return self.getAuth().signInWithCredential(credential); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb); }; @@ -1459,7 +1459,7 @@ firebaseui.auth.AuthUI.prototype.startSignInWithPopup = function(provider) { return self.getAuth().signInWithPopup(provider); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb); }; @@ -1499,7 +1499,7 @@ firebaseui.auth.AuthUI.prototype.startSignInWithRedirect = function(provider) { return self.getAuth().signInWithRedirect(provider); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb).then( function() { @@ -1556,7 +1556,7 @@ firebaseui.auth.AuthUI.prototype.startSignInWithPhoneNumber = }); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb); }; @@ -1669,7 +1669,7 @@ firebaseui.auth.AuthUI.prototype.finishSignInAndRetrieveDataWithAuthResult = }); } }; - // Initialize current user if auto upgrade is enabled beforing running + // Initialize current user if auto upgrade is enabled before running // callback and returning result. return this.initializeForAutoUpgrade_(cb); }; From 12cae3b059ff6866f22d0e84216beb49ea9e19b4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:39:26 -0400 Subject: [PATCH 05/61] spelling: button Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- firebaseuihandler/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebaseuihandler/README.md b/firebaseuihandler/README.md index 30c37517..b0028bb1 100644 --- a/firebaseuihandler/README.md +++ b/firebaseuihandler/README.md @@ -388,7 +388,7 @@ interface Callbacks { // Interface that represents the tenant-level configurations. interface TenantConfig { - // The full label for the tenant in the tenant selection buttion. Only needed + // The full label for the tenant in the tenant selection button. Only needed // if you are using the option first mode. // When not provided, the "Sign in to $displayName" label is used. fullLabel?: string; From 2e501a8edbe72c55e520d56a7fc866d73d0fb815 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:30:54 -0400 Subject: [PATCH 06/61] spelling: cannot Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/utils/util.js | 2 +- soy/strings.soy | 2 +- translations/en-GB.xtb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/javascript/utils/util.js b/javascript/utils/util.js index b93f35a1..a2041242 100644 --- a/javascript/utils/util.js +++ b/javascript/utils/util.js @@ -221,7 +221,7 @@ firebaseui.auth.util.popup = /** * Gets the element in the current document by the query selector. * If an Element is passed in, it is returned. - * An `Error` is thrown if the element can not be found. + * An `Error` is thrown if the element cannot be found. * * @param {string|Element} element The element or the query selector. * @param {string=} opt_notFoundDesc Error description when element not diff --git a/soy/strings.soy b/soy/strings.soy index c5bc58c3..f94b3acf 100644 --- a/soy/strings.soy +++ b/soy/strings.soy @@ -418,7 +418,7 @@ {/msg} {case 'failed-precondition'} {msg desc="Error message for the failed precondition error."} - Request can not be executed in the current system state. + Request cannot be executed in the current system state. {/msg} {case 'out-of-range'} {msg desc="Error message for the out of range error."} diff --git a/translations/en-GB.xtb b/translations/en-GB.xtb index 952e492d..e989773e 100644 --- a/translations/en-GB.xtb +++ b/translations/en-GB.xtb @@ -380,7 +380,7 @@ First name &amp; surname Grenada Western Sahara -Request can not be executed in the current system state. +Request cannot be executed in the current system state. An unknown error occurred. You've already used to sign in. Enter your password for that account. Sign-in email sent From 0efb4d8cff4a8cbb53e25ab935c6a7cd5ea36631 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:39:31 -0400 Subject: [PATCH 07/61] spelling: checks Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/utils/acclient.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/javascript/utils/acclient.js b/javascript/utils/acclient.js index a31ee784..72df7f5e 100644 --- a/javascript/utils/acclient.js +++ b/javascript/utils/acclient.js @@ -283,7 +283,7 @@ firebaseui.auth.acClient.DummyApi = class { /** - * Checkes if accountchooser.com is disabled. The callback is always invoked + * Checks if accountchooser.com is disabled. The callback is always invoked * with a `true`. * * @param {function(boolean=, Object=)} callback The callback function. @@ -294,7 +294,7 @@ firebaseui.auth.acClient.DummyApi = class { /** - * Checkes if the accountchooser.com is empty. The callback is always invoked + * Checks if the accountchooser.com is empty. The callback is always invoked * with a service unavailable error. * * @param {function(boolean=, Object=)} callback The callback function. @@ -305,7 +305,7 @@ firebaseui.auth.acClient.DummyApi = class { /** - * Checkes if the account is in accountchooser.com. The callback is always + * Checks if the account is in accountchooser.com. The callback is always * invoked with a service unavailable error. * * @param {Object} account The account to check. @@ -317,7 +317,7 @@ firebaseui.auth.acClient.DummyApi = class { /** - * Checkes if the account should be updated. The callback is always invoked + * Checks if the account should be updated. The callback is always invoked * with a service unavailable error. * * @param {Object} account The account to check. From fc7d95d5d91c4da89bc3efc41cb585ebd662a008 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:39:48 -0400 Subject: [PATCH 08/61] spelling: compilation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- gulpfile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gulpfile.js b/gulpfile.js index 59130fcc..49f06997 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -153,7 +153,7 @@ gulp.task('build-soy', () => new Promise((resolve, reject) => { * @param {!Array} srcs The JS sources to compile. * @param {string} out The path to the output JS file. * @param {!Object} args Additional arguments to Closure compiler. - * @return {*} A stream that finishes when compliation finishes. + * @return {*} A stream that finishes when compilation finishes. */ function compile(srcs, out, args) { // Get the compiler arguments, using the defaults if not specified. From e1eac888a3d7bbd2e34c9f0921d3dd3e14e07495 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:39:54 -0400 Subject: [PATCH 09/61] spelling: component Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/page/blank.js | 2 +- javascript/ui/page/callback.js | 2 +- javascript/ui/page/spinner.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/javascript/ui/page/blank.js b/javascript/ui/page/blank.js index 28af20da..6068ee51 100644 --- a/javascript/ui/page/blank.js +++ b/javascript/ui/page/blank.js @@ -24,7 +24,7 @@ goog.requireType('goog.dom.DomHelper'); /** - * Blank page UI componenet. + * Blank page UI component. */ firebaseui.auth.ui.page.Blank = class extends firebaseui.auth.ui.page.Base { /** diff --git a/javascript/ui/page/callback.js b/javascript/ui/page/callback.js index 3674daf4..b8e7d7ed 100644 --- a/javascript/ui/page/callback.js +++ b/javascript/ui/page/callback.js @@ -25,7 +25,7 @@ goog.requireType('goog.dom.DomHelper'); /** - * Callback page UI componenet. + * Callback page UI component. */ firebaseui.auth.ui.page.Callback = class extends firebaseui.auth.ui.page.Base { /** diff --git a/javascript/ui/page/spinner.js b/javascript/ui/page/spinner.js index 789543b7..2f565fca 100644 --- a/javascript/ui/page/spinner.js +++ b/javascript/ui/page/spinner.js @@ -24,7 +24,7 @@ goog.requireType('goog.dom.DomHelper'); /** - * Spinner page UI componenet. + * Spinner page UI component. */ firebaseui.auth.ui.page.Spinner = class extends firebaseui.auth.ui.page.Base { /** From 38c94bdec59bdd3285aeff19080508452d6abc5a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:40:01 -0400 Subject: [PATCH 10/61] spelling: configurations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/widgets/firebaseuihandler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/widgets/firebaseuihandler.js b/javascript/widgets/firebaseuihandler.js index 730f849d..f522c5c8 100644 --- a/javascript/widgets/firebaseuihandler.js +++ b/javascript/widgets/firebaseuihandler.js @@ -604,7 +604,7 @@ function getLocalizedErrorMessage(code) { /** * The project level configuration object. * authDomain: The Auth domain. - * tenants: The tenant level configuations keyed by tenant ID or '_' for + * tenants: The tenant level configurations keyed by tenant ID or '_' for * top-level project config. * @typedef {{ * authDomain: string, From 29943490cc6a8cf042b1e3f83e711ebd9353dcd0 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:42:21 -0400 Subject: [PATCH 11/61] spelling: contains Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/element/phonenumber.js | 2 +- javascript/utils/phonenumber.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/javascript/ui/element/phonenumber.js b/javascript/ui/element/phonenumber.js index 2807fe43..b178ca0b 100644 --- a/javascript/ui/element/phonenumber.js +++ b/javascript/ui/element/phonenumber.js @@ -131,7 +131,7 @@ element.phoneNumber.initPhoneNumberElement = function(opt_lookupTree, // Get current country ID selected. var selectedCountry = firebaseui.auth.data.country.getCountryByKey( this.phoneNumberSelectedCountryId_); - // Get matching countries if national number countains it. + // Get matching countries if national number contains it. var countries = lookupTree.search(nationalNumber); var predefinedDefaultCountryAvailable = element.phoneNumber.isCountryAvailable_( diff --git a/javascript/utils/phonenumber.js b/javascript/utils/phonenumber.js index 58ebdbe3..4208a893 100644 --- a/javascript/utils/phonenumber.js +++ b/javascript/utils/phonenumber.js @@ -47,7 +47,7 @@ firebaseui.auth.PhoneNumber = class { // but that dependency is too large to bundle with FirebaseUI-web, so we // will attempt a best effort approach to parse the 2 components. var trimmedPhoneNumber = goog.string.trim(phoneNumberStr); - // Get matching countries if national number countains it. + // Get matching countries if national number contains it. var countries = firebaseui.auth.data.country.LOOKUP_TREE.search(trimmedPhoneNumber); if (countries.length > 0) { From 35cda5e69c47bd6b6637bbc8d64635a87c8d2ab6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 16:08:15 -0400 Subject: [PATCH 12/61] spelling: contractor Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3ee36e57..9d966373 100644 --- a/README.md +++ b/README.md @@ -883,7 +883,7 @@ ui.start('#firebaseui-auth-container', { provider: 'saml.myProvider', providerName: 'MySAMLProvider', // To override the full label of the button. - // fullLabel: 'Constractor Portal', + // fullLabel: 'Contractor Portal', buttonColor: '#2F2F2F', iconUrl: '' } From 6e1b42e0aad01e641b5fb713d5db36074c6c5582 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 17:00:18 -0400 Subject: [PATCH 13/61] spelling: current Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/page/base.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/ui/page/base.js b/javascript/ui/page/base.js index ff9d4735..6b826d2f 100644 --- a/javascript/ui/page/base.js +++ b/javascript/ui/page/base.js @@ -188,7 +188,7 @@ firebaseui.auth.ui.page.Base.EventType = { /** - * @return {?string} The identifier for the urrent page. + * @return {?string} The identifier for the current page. */ firebaseui.auth.ui.page.Base.prototype.getPageId = function() { return this.pageId_; From fe1d9160ad1817d1309f60b974d4b949ab000618 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:42:40 -0400 Subject: [PATCH 14/61] spelling: determined Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- firebaseuihandler/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firebaseuihandler/README.md b/firebaseuihandler/README.md index b0028bb1..f27e73fa 100644 --- a/firebaseuihandler/README.md +++ b/firebaseuihandler/README.md @@ -416,10 +416,10 @@ interface TenantConfig { // selection screen. signInOptions: Array; // The URL of the Terms of Service page or a callback function to be invoked - // when Terms of Service link is clicked after the tenant is determind. + // when Terms of Service link is clicked after the tenant is determined. tosUrl?: (() => void) | string; // The URL of the Terms of Service page or a callback function to be invoked - // when Terms of Service link is clicked after the tenant is determind. + // when Terms of Service link is clicked after the tenant is determined. privacyPolicyUrl?: (() => void) | string; } From fdbb99cf576e7c569b5882a957914f87d6e9078a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:42:52 -0400 Subject: [PATCH 15/61] spelling: different Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- firebase-externs/firebase-auth-externs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebase-externs/firebase-auth-externs.js b/firebase-externs/firebase-auth-externs.js index f286f66c..96057545 100644 --- a/firebase-externs/firebase-auth-externs.js +++ b/firebase-externs/firebase-auth-externs.js @@ -2057,7 +2057,7 @@ firebase.auth.Auth.prototype.signInAnonymously = function () {}; *

Error Codes

*
*
auth/invalid-user-token
- *
Thrown if the user to be updated belongs to a diffent Firebase + *
Thrown if the user to be updated belongs to a different Firebase * project.
*
auth/user-token-expired
*
Thrown if the token of the user to be updated is expired.
From 56f1f7f7885a2db01a6cb31a3188e9782c204b2d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:01 -0400 Subject: [PATCH 16/61] spelling: displayed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/widgets/handler/unsupportedprovider_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/widgets/handler/unsupportedprovider_test.js b/javascript/widgets/handler/unsupportedprovider_test.js index 9d837916..2da77a2f 100644 --- a/javascript/widgets/handler/unsupportedprovider_test.js +++ b/javascript/widgets/handler/unsupportedprovider_test.js @@ -30,7 +30,7 @@ function testHandleUnsupportedProvider() { assertUnsupportedProviderPage('user@example.com'); // Click recover password button. submitForm(); - // Verify that password revover screen is dispalyed. + // Verify that password revover screen is displayed. assertPasswordRecoveryPage(); submitForm(); From 393f857e2cc4b7a9cac1202a9c31f43f50e42cfd Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:07 -0400 Subject: [PATCH 17/61] spelling: document Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/page/emaillinksigninlinking_test.js | 2 +- .../ui/page/emaillinksigninlinkingdifferentdevice_test.js | 2 +- javascript/ui/page/emailmismatch_test.js | 2 +- javascript/ui/page/federatedlinking_test.js | 2 +- javascript/ui/page/notice_test.js | 2 +- javascript/ui/page/passwordlinking_test.js | 2 +- javascript/ui/page/passwordrecovery_test.js | 2 +- javascript/ui/page/passwordreset_test.js | 2 +- javascript/ui/page/passwordsignin_test.js | 2 +- javascript/ui/page/providermatchbyemail_test.js | 2 +- javascript/ui/page/providersignin_test.js | 2 +- javascript/ui/page/signin_test.js | 2 +- javascript/ui/page/unsupportedprovider_test.js | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/javascript/ui/page/emaillinksigninlinking_test.js b/javascript/ui/page/emaillinksigninlinking_test.js index d989cd31..662c5b73 100644 --- a/javascript/ui/page/emaillinksigninlinking_test.js +++ b/javascript/ui/page/emaillinksigninlinking_test.js @@ -95,7 +95,7 @@ function testInitialFocus() { function testEmailLinkSignInLinking_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.EmailLinkSignInLinking( diff --git a/javascript/ui/page/emaillinksigninlinkingdifferentdevice_test.js b/javascript/ui/page/emaillinksigninlinkingdifferentdevice_test.js index 3e4da0a4..02c946d0 100644 --- a/javascript/ui/page/emaillinksigninlinkingdifferentdevice_test.js +++ b/javascript/ui/page/emaillinksigninlinkingdifferentdevice_test.js @@ -96,7 +96,7 @@ function testInitialFocus() { function testEmailLinkSignInLinkingDifferentDevice_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.EmailLinkSignInLinkingDifferentDevice( diff --git a/javascript/ui/page/emailmismatch_test.js b/javascript/ui/page/emailmismatch_test.js index 0317897a..83fb12ea 100644 --- a/javascript/ui/page/emailmismatch_test.js +++ b/javascript/ui/page/emailmismatch_test.js @@ -99,7 +99,7 @@ function testInitialFocus() { function testEmailMismatch_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.EmailMismatch( diff --git a/javascript/ui/page/federatedlinking_test.js b/javascript/ui/page/federatedlinking_test.js index 001c0c5b..cc09f537 100644 --- a/javascript/ui/page/federatedlinking_test.js +++ b/javascript/ui/page/federatedlinking_test.js @@ -99,7 +99,7 @@ function testInitialFocus() { function testFederatedLinking_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.FederatedLinking( diff --git a/javascript/ui/page/notice_test.js b/javascript/ui/page/notice_test.js index 4be4de1b..e4477ca6 100644 --- a/javascript/ui/page/notice_test.js +++ b/javascript/ui/page/notice_test.js @@ -107,7 +107,7 @@ function testInitialFocus() { function testPasswordRecoveryEmailSent_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.PasswordRecoveryEmailSent( diff --git a/javascript/ui/page/passwordlinking_test.js b/javascript/ui/page/passwordlinking_test.js index 17976ac5..70b68c7a 100644 --- a/javascript/ui/page/passwordlinking_test.js +++ b/javascript/ui/page/passwordlinking_test.js @@ -111,7 +111,7 @@ function testSubmitOnPasswordEnter() { function testPasswordLinking_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.PasswordLinking( diff --git a/javascript/ui/page/passwordrecovery_test.js b/javascript/ui/page/passwordrecovery_test.js index 9e2dbeb7..764de7a9 100644 --- a/javascript/ui/page/passwordrecovery_test.js +++ b/javascript/ui/page/passwordrecovery_test.js @@ -112,7 +112,7 @@ function testInitialFocus_email() { function testPasswordRecovery_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.PasswordRecovery( diff --git a/javascript/ui/page/passwordreset_test.js b/javascript/ui/page/passwordreset_test.js index 96e27c6d..4949cd93 100644 --- a/javascript/ui/page/passwordreset_test.js +++ b/javascript/ui/page/passwordreset_test.js @@ -97,7 +97,7 @@ function testSubmitOnNewPasswordEnter() { function testPasswordReset_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.PasswordReset( diff --git a/javascript/ui/page/passwordsignin_test.js b/javascript/ui/page/passwordsignin_test.js index 27337324..c84cf5c2 100644 --- a/javascript/ui/page/passwordsignin_test.js +++ b/javascript/ui/page/passwordsignin_test.js @@ -220,7 +220,7 @@ function testPasswordSignIn_footer_noUrl() { function testPasswordSignIn_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.PasswordSignIn( diff --git a/javascript/ui/page/providermatchbyemail_test.js b/javascript/ui/page/providermatchbyemail_test.js index dc58ec60..d0a8857e 100644 --- a/javascript/ui/page/providermatchbyemail_test.js +++ b/javascript/ui/page/providermatchbyemail_test.js @@ -133,7 +133,7 @@ function testProviderMatchByEmail_noTosPp() { function testProviderMatchByEmail_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.ProviderMatchByEmail( diff --git a/javascript/ui/page/providersignin_test.js b/javascript/ui/page/providersignin_test.js index 3befc306..25c39d86 100644 --- a/javascript/ui/page/providersignin_test.js +++ b/javascript/ui/page/providersignin_test.js @@ -88,7 +88,7 @@ testSuite({ testProviderSignIn_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new ProviderSignIn( diff --git a/javascript/ui/page/signin_test.js b/javascript/ui/page/signin_test.js index bf13bd50..6efba46a 100644 --- a/javascript/ui/page/signin_test.js +++ b/javascript/ui/page/signin_test.js @@ -188,7 +188,7 @@ function testSignIn_footerOnly_noUrl() { function testSignIn_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.SignIn( diff --git a/javascript/ui/page/unsupportedprovider_test.js b/javascript/ui/page/unsupportedprovider_test.js index 399c66bf..64e971aa 100644 --- a/javascript/ui/page/unsupportedprovider_test.js +++ b/javascript/ui/page/unsupportedprovider_test.js @@ -96,7 +96,7 @@ function testInitialFocus() { function testUnsupportedProvider_pageEvents() { // Run page event tests. // Dispose previously created container since test must run before rendering - // the component in docoument. + // the component in document. component.dispose(); // Initialize component. component = new firebaseui.auth.ui.page.UnsupportedProvider( From 5aefb7b74e714527fac55a67093aa49f7abd6896 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:16 -0400 Subject: [PATCH 18/61] spelling: doesn't Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/utils/acclient.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/utils/acclient.js b/javascript/utils/acclient.js index 72df7f5e..b2aa3a0e 100644 --- a/javascript/utils/acclient.js +++ b/javascript/utils/acclient.js @@ -185,7 +185,7 @@ firebaseui.auth.acClient.tryStoreAccount = firebaseui.auth.acClient.api_.checkAccountExist(acAccount, function(exist, error) { if (!exist && !error) { - // It doens't exist in accountchooser.com. + // It doesn't exist in accountchooser.com. firebaseui.auth.acClient.api_.store([acAccount], options); } else if (!error) { // It exists. Check whether we should update it. From 27c8e15a284c3f018eb16139e87a5ed118f24009 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:28 -0400 Subject: [PATCH 19/61] spelling: emaillink Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/page/emaillinksigninsent_test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/javascript/ui/page/emaillinksigninsent_test.js b/javascript/ui/page/emaillinksigninsent_test.js index 1736dde2..cf89112d 100644 --- a/javascript/ui/page/emaillinksigninsent_test.js +++ b/javascript/ui/page/emaillinksigninsent_test.js @@ -90,10 +90,10 @@ function tearDown() { function testEmailLinkSignInSent_troubleGettingEmailLinkClicked() { - var troubleGettingEmaillink = component.getTroubleGettingEmailLink(); - assertNotNull(troubleGettingEmaillink); + var troubleGettingEmailLink = component.getTroubleGettingEmailLink(); + assertNotNull(troubleGettingEmailLink); assertFalse(troubleGettingEmailClicked); - goog.testing.events.fireClickSequence(troubleGettingEmaillink); + goog.testing.events.fireClickSequence(troubleGettingEmailLink); assertTrue(troubleGettingEmailClicked); } From 4b59e9c09873e9b0ecdf53e33c3b3ab63a4e8c25 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:37 -0400 Subject: [PATCH 20/61] spelling: encrypted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/utils/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/utils/storage.js b/javascript/utils/storage.js index a87eeb6e..0fdac71f 100644 --- a/javascript/utils/storage.js +++ b/javascript/utils/storage.js @@ -463,7 +463,7 @@ storage.removeEncryptedPendingCredential = function(opt_id) { /** - * Stores the encrpted pending email credential for the specified application + * Stores the encrypted pending email credential for the specified application * ID. * * @param {string} encryptionKey The encryption key to encrypt the credential. From bf9324339023bca29cf62f36540760041915a179 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:45 -0400 Subject: [PATCH 21/61] spelling: facilitate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/testing/mockhelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/testing/mockhelper.js b/javascript/testing/mockhelper.js index 13cf9887..f2155dba 100644 --- a/javascript/testing/mockhelper.js +++ b/javascript/testing/mockhelper.js @@ -13,7 +13,7 @@ */ /** - * @fileoverview Mock helper used to faciliate creating Firebase component mocks + * @fileoverview Mock helper used to facilitate creating Firebase component mocks * for testing. */ From a5be5edd53d78d2721034f35aed5d7d85477156e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:43:59 -0400 Subject: [PATCH 22/61] spelling: firebaseui Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/widgets/handler/testhelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/widgets/handler/testhelper.js b/javascript/widgets/handler/testhelper.js index 0c215f4a..48385aa1 100644 --- a/javascript/widgets/handler/testhelper.js +++ b/javascript/widgets/handler/testhelper.js @@ -1459,7 +1459,7 @@ function signInSuccessWithAuthResultCallback(redirect, opt_manualRedirect) { /** - * @param {!fireabaseui.auth.AuthResult} authResult The returned auth result. + * @param {!firebaseui.auth.AuthResult} authResult The returned auth result. * @param {string=} opt_redirectUrl The redirect URL if available. */ function assertSignInSuccessWithAuthResultCallbackInvoked( From 5afae7c5cc5e642ad085a58caafbad691272305b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:45:21 -0400 Subject: [PATCH 23/61] spelling: getting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- javascript/ui/page/emaillinksigninsent.js | 10 +++++----- javascript/ui/page/emaillinksigninsent_test.js | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/javascript/ui/page/emaillinksigninsent.js b/javascript/ui/page/emaillinksigninsent.js index ecee3886..97065dad 100644 --- a/javascript/ui/page/emaillinksigninsent.js +++ b/javascript/ui/page/emaillinksigninsent.js @@ -32,7 +32,7 @@ firebaseui.auth.ui.page.EmailLinkSignInSent = class extends firebaseui.auth.ui.page.Base { /** * @param {string} email The email formerly used to sign in. - * @param {function()} onTroubleGetingEmailLinkClick Callback to invoke when + * @param {function()} onTroubleGettingEmailLinkClick Callback to invoke when * the trouble getting email link is clicked. * @param {function()} onCancelClick Callback to invoke when the back button * is clicked. @@ -43,7 +43,7 @@ firebaseui.auth.ui.page.EmailLinkSignInSent = * @param {?goog.dom.DomHelper=} opt_domHelper Optional DOM helper. */ constructor( - email, onTroubleGetingEmailLinkClick, onCancelClick, opt_tosCallback, + email, onTroubleGettingEmailLinkClick, onCancelClick, opt_tosCallback, opt_privacyPolicyCallback, opt_domHelper) { // Extend base page class and render email link sign in sent soy template. super( @@ -52,7 +52,7 @@ firebaseui.auth.ui.page.EmailLinkSignInSent = tosCallback: opt_tosCallback, privacyPolicyCallback: opt_privacyPolicyCallback }); - this.onTroubleGetingEmailLinkClick_ = onTroubleGetingEmailLinkClick; + this.onTroubleGettingEmailLinkClick_ = onTroubleGettingEmailLinkClick; this.onCancelClick_ = onCancelClick; } @@ -67,7 +67,7 @@ firebaseui.auth.ui.page.EmailLinkSignInSent = // Handle action event for trouble getting email link. firebaseui.auth.ui.element.listenForActionEvent( this, this.getTroubleGettingEmailLink(), function(e) { - self.onTroubleGetingEmailLinkClick_(); + self.onTroubleGettingEmailLinkClick_(); }); // Set initial focus on the cancel button. this.getSecondaryLinkElement().focus(); @@ -83,7 +83,7 @@ firebaseui.auth.ui.page.EmailLinkSignInSent = /** @override */ disposeInternal() { - this.onTroubleGetingEmailLinkClick_ = null; + this.onTroubleGettingEmailLinkClick_ = null; this.onCancelClick_ = null; super.disposeInternal(); } diff --git a/javascript/ui/page/emaillinksigninsent_test.js b/javascript/ui/page/emaillinksigninsent_test.js index cf89112d..54a24944 100644 --- a/javascript/ui/page/emaillinksigninsent_test.js +++ b/javascript/ui/page/emaillinksigninsent_test.js @@ -44,7 +44,7 @@ var pageTestHelper = new firebaseui.auth.ui.page.PageTestHelper().registerTests(); var troubleGettingEmailClicked; -var onTroubleGetingEmailLinkClick; +var onTroubleGettingEmailLinkClick; function setUp() { @@ -52,14 +52,14 @@ function setUp() { mockClock = new goog.testing.MockClock(); mockClock.install(); troubleGettingEmailClicked = false; - onTroubleGetingEmailLinkClick = function() { + onTroubleGettingEmailLinkClick = function() { troubleGettingEmailClicked = true; }; root = goog.dom.createDom(goog.dom.TagName.DIV); document.body.appendChild(root); component = new firebaseui.auth.ui.page.EmailLinkSignInSent( 'user@example.com', - onTroubleGetingEmailLinkClick, + onTroubleGettingEmailLinkClick, goog.bind( firebaseui.auth.ui.element.FormTestHelper.prototype.onLinkClick, formTestHelper), @@ -113,7 +113,7 @@ function testEmailLinkSignInSent_pageEvents() { // Initialize component. component = new firebaseui.auth.ui.page.EmailLinkSignInSent( 'user@example.com', - onTroubleGetingEmailLinkClick, + onTroubleGettingEmailLinkClick, goog.bind( firebaseui.auth.ui.element.FormTestHelper.prototype.onLinkClick, formTestHelper)); From 1f347462231991f54b061b8982f42c7cff67fa71 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 29 May 2024 15:31:00 -0400 Subject: [PATCH 24/61] spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- CONTRIBUTING.md | 2 +- README.md | 6 +++--- buildtools/country_data/generate_country_data.sh | 2 +- buildtools/run_tests.sh | 2 +- firebase-externs/firebase-auth-externs.js | 6 +++--- protractor.conf.js | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index d37caece..6d6ae073 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -8,7 +8,7 @@ about: Create a report to help us improve