Firebase ML can gracefully accept unknown fields in ModelResponse (#989)

Author: ifielker

package-lock.json

@@ -271,7 +271,7 @@ export class Model {
     if (model.modelHash) {
       this.modelHash = model.modelHash;
     }
-    if (model.tfliteModel) {
+    if (model.tfliteModel?.gcsTfliteUri) {
       this.tfliteModel = {
         gcsTfliteUri: model.tfliteModel.gcsTfliteUri,
         sizeBytes: model.tfliteModel.sizeBytes,

src/machine-learning/machine-learning.ts

@@ -105,6 +105,21 @@ describe('MachineLearning', () => {
   };
   const MODEL2 = new Model(MODEL_RESPONSE2);
 
+  const MODEL_RESPONSE3: any = {
+    name: 'projects/test-project/models/3456789',
+    createTime: '2020-02-07T23:45:23.288047Z',
+    updateTime: '2020-02-08T23:45:23.288047Z',
+    etag: 'etag345',
+    modelHash: 'modelHash345',
+    displayName: 'model_3',
+    tags: ['tag_3', 'tag_4'],
+    state: { published: true },
+    tfliteModel: {
+      managedUpload: true,
+      sizeBytes: 22200222,
+    },
+  };
+
   const STATUS_ERROR_RESPONSE: {
     code: number;
     message: string;
@@ -245,8 +260,25 @@ describe('MachineLearning', () => {
         'gs://test-project-bucket/Firebase/ML/Models/model1.tflite');
       expect(tflite.sizeBytes).to.be.equal(16900988);
     });
+
+    it('should accept unknown fields gracefully', () => {
+      const model = new Model(MODEL_RESPONSE3);
+      expect(model.modelId).to.equal('3456789');
+      expect(model.displayName).to.equal('model_3');
+      expect(model.tags).to.deep.equal(['tag_3', 'tag_4']);
+      expect(model.createTime).to.equal(CREATE_TIME_UTC);
+      expect(model.updateTime).to.equal(UPDATE_TIME_UTC);
+      expect(model.validationError).to.be.undefined;
+      expect(model.published).to.be.true;
+      expect(model.etag).to.equal('etag345');
+      expect(model.modelHash).to.equal('modelHash345');
+      expect(model.tfliteModel).to.be.undefined;
+    });
+
   });
 
+
+
   describe('getModel', () => {
     it('should propagate API errors', () => {
       const stub = sinon