-
Notifications
You must be signed in to change notification settings - Fork 409
🐛 [firestore-send-email] Validation in version 0.2.1 breaks existing behaviour #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
HI, can you provide your extension configuration? Are you using sendgrid, or some other smtp provider? |
ah reproduced this, looking into a fix now. Thanks for raising! |
In the meantime if you want to downgrade you can alter the URL here, specify the version at the end: https://console.firebase.google.com/project/_/extensions/install?ref=firebase%[email protected] |
Reopening until i release this. After testing I need to make some more changes before we release. |
I using a standard smtp provider (username + passwort) without any OAuth2 |
No worries! Plan to get a release out tomorrow fixing this. |
For the sake of completeness: this is an example for an email that works fine in version 0.2.0 and that fails due to validation errors in version 0.2.1:
|
shouldn't attachments be an array there?
I mean it may have still failed due to poor validation |
Yes it is an array - only the text i copied to this issue was not correct. In my app/database it is always an array. |
but also i'm confused, https://nodemailer.com/message/attachments/
|
ah - i generated this json based on a screenshot of a firestore database entry with copilot aaaand did not check the result. I'm fixing it. |
Reopening again until this is fixed - there are release process issues now, waiting on those to be fixed |
triggered release now, closing as complete. If the issue persists somehow then do open a new issue! |
[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:
with the firebase tag.
google group.
Firebase support directly.
[REQUIRED] Step 2: Describe your configuration
firestore-send-email
[REQUIRED] Step 3: Describe the problem
New validation in Version 0.2.1 breaks existing behaviour. The new validation forces html- or text- property to be not null (error: "ValidationError: Invalid email configuration: Field 'message.html' must be a string."). When using templates those fields are not in use (at least in my case). So updating to version 0.2.1 breaks my production app.
The field "template" is also not nullable anymore (error: "Field 'template' must be object")
Is there a way to deactivte the validation? Is there a way for my to go back to a previous version?
Expected result
Actual result
The text was updated successfully, but these errors were encountered: