Skip to content

Commit 96b6af6

Browse files
committed
fix(firestore-bigquery-change-tracker): keep partition value on delete using old data
1 parent e100988 commit 96b6af6

File tree

1 file changed

+2
-2
lines changed
  • firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery

1 file changed

+2
-2
lines changed

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/partitioning.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FirestoreBigQueryEventHistoryTrackerConfig } from ".";
2-
import { FirestoreDocumentChangeEvent } from "..";
2+
import { ChangeType, FirestoreDocumentChangeEvent } from "..";
33
import * as firebase from "firebase-admin";
44

55
import * as logs from "../logs";
@@ -199,7 +199,7 @@ export class Partitioning {
199199

200200
const firestoreFieldName = this.config.timePartitioningFirestoreField;
201201
const fieldName = this.config.timePartitioningField;
202-
const fieldValue = event.data[firestoreFieldName];
202+
const fieldValue = event.operation === ChangeType.DELETE ? event.oldData[firestoreFieldName] : event.data[firestoreFieldName];
203203

204204
if (!fieldName || !fieldValue) {
205205
return {};

0 commit comments

Comments
 (0)