Skip to content

feat: allow git-proxy to be configured both by environment as well as config file(s) #382

@coopernetes

Description

@coopernetes

Tracking overall enhancements to how the git-proxy application receives its user configurable values.

Tasks

  • Allow all user settings to be defined in a JSON file (largely complete but remove any hard-coded values from src)
  • Allow GIT_PROXY_* environment variables to override file-based settings
  • Add test cases to configuration parsing for all settings (improve coverage)
  • Adopt a proper library to handle externalized config

LGTM - as a future enhancement, we should expose the server ports as both file-based config (via proxy.config.json) as well as environment variables. We should have this available for all our configurable values, merge or reconcile between the two sources and allow users to choose whichever method best suits their deployment to configure ports & other values.

Originally posted by @coopernetes in #379 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomersprotocolEverything related with the developer (git) experiencetech-debt

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions