-
Notifications
You must be signed in to change notification settings - Fork 142
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersprotocolEverything related with the developer (git) experienceEverything related with the developer (git) experiencetech-debt
Milestone
Description
Tracking overall enhancements to how the git-proxy application receives its user configurable values.
Tasks
- Allow all user settings to be defined in a JSON file (largely complete but remove any hard-coded values from src)
- Allow
GIT_PROXY_*
environment variables to override file-based settings - Add test cases to configuration parsing for all settings (improve coverage)
- Adopt a proper library to handle externalized config
LGTM - as a future enhancement, we should expose the server ports as both file-based config (via proxy.config.json) as well as environment variables. We should have this available for all our configurable values, merge or reconcile between the two sources and allow users to choose whichever method best suits their deployment to configure ports & other values.
Originally posted by @coopernetes in #379 (review)
JamieSlome
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersprotocolEverything related with the developer (git) experienceEverything related with the developer (git) experiencetech-debt