From 7014df77c07bf800be5b8459a5006c6c7d2675ed Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu, 18 Jun 2026 12:19:10 +0000 Subject: [PATCH] refactor(filter): optimize logic_and Cartesian product computation using list comprehension and dict union operator Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com> --- pydivert/filter.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/pydivert/filter.py b/pydivert/filter.py index 8df61d5..afcfe9d 100644 --- a/pydivert/filter.py +++ b/pydivert/filter.py @@ -156,13 +156,7 @@ def logic_and(self, children): for child in children: if not isinstance(child, list) or not child: continue # pragma: no cover - new_result = [] - for existing_rule in result_rules: - for new_rule_part in child: - merged = existing_rule.copy() - merged.update(new_rule_part) - new_result.append(merged) - result_rules = new_result + result_rules = [existing | new for existing in result_rules for new in child] return result_rules def logic_or(self, children):