Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation around signalling #548

Open
aakilfernandes opened this issue Sep 17, 2019 · 3 comments
Open

Improve documentation around signalling #548

aakilfernandes opened this issue Sep 17, 2019 · 3 comments

Comments

@aakilfernandes
Copy link

aakilfernandes commented Sep 17, 2019

Not a bug but a suggestion:

I think it'd be easier for newbies if trickle was set to false by default. While the examples use clients on a same context and multiple candidates are shared automatically, developers will likely use a signaling server. When building out a signaling server, its not immediately obvious you need to handle multiple signals from the same peer. Setting trickle to false by default would hopefully save a lot of headaches.

@t-mullen
Copy link
Collaborator

t-mullen commented Sep 17, 2019

trickle:false won't ensure only a single signal message. If you addStream after negotiation completes, you'll get more messages.

Disabling trickle is kind of terrible - it stalls establishing the connection until ICE fully completes. I don't think poor performance should be the default.

Maybe this is a documentation bug rather than an issue with the defaults?

@aakilfernandes
Copy link
Author

Thats a fair point. Didn't realize addStream would require additional signaling.

@t-mullen t-mullen changed the title trickle: false as default Improve documentation around signalling Feb 4, 2020
@shlok-ps
Copy link

shlok-ps commented Sep 7, 2020

Hello @aakilfernandes @t-mullen it seems the documentation isn't added yet, what are the signaling needed for addstream?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants