Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record OTel metrics in host components #2564

Open
calebschoepp opened this issue Jun 14, 2024 · 2 comments · May be fixed by #2741
Open

Record OTel metrics in host components #2564

calebschoepp opened this issue Jun 14, 2024 · 2 comments · May be fixed by #2741
Assignees
@me-diru
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@calebschoepp
Copy link
Collaborator

It would be nice to record metrics in host components e.g. counter spin.key_value.set or counter spin.llm.infer
@calebschoepp calebschoepp added good first issue Good for newcomers enhancement New feature or request labels Jun 14, 2024
@me-diru me-diru self-assigned this Jun 25, 2024
@me-diru me-diru linked a pull request Aug 21, 2024 that will close this issue
Open
@calebschoepp
Copy link
Collaborator Author

@me-diru were you still planning on working on this? Totally fine if you weren't planning to.

@me-diru
Copy link
Contributor

me-diru commented Sep 5, 2024

Hi! Yes, at least the basic metrics are done, and I want to test it after Lann has landed on that patch. I will look into it and see where it takes me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@me-diru me-diru

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add counter telemetry(WIP) me-diru/spin
2 participants
@calebschoepp @me-diru