Skip to content

Interpretation for many more DTCs on Volvo vehicles #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaeegg wants to merge 6 commits into from
Closed

Interpretation for many more DTCs on Volvo vehicles #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9261ad
tests: scantool_850 DTC decoding
aaeegg May 7, 2024
33de55e
scantool_850: Handle DTCs with descriptions but unknown designation
aaeegg May 7, 2024
6d0b69a
scantool_850: Print warning for unconfirmed DTC table entries
aaeegg May 12, 2024
29c10e1
scantool_850: add tips option to dtc command
aaeegg May 12, 2024
5fe23ea
scantool_850: Interpretation for many more DTCs
aaeegg May 13, 2024
3ce5ee0
scantool_850: supply DTC table processing script for reference
aaeegg Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 49 additions & 9 deletions scantool/scantool_850.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const struct cmd_tbl_entry v850_cmd_table[] = {
cmd_850_readnv, 0, NULL},
{ "id", "id", "Display ECU identification",
cmd_850_id, 0, NULL},
{ "dtc", "dtc", "Retrieve DTCs",
{ "dtc", "dtc [tips]", "Retrieve DTCs",
cmd_850_dtc, 0, NULL},
{ "cleardtc", "cleardtc", "Clear DTCs from ECU",
cmd_850_cleardtc, 0, NULL},
Expand Down Expand Up @@ -231,17 +231,20 @@ static const char *current_ecu_desc(void) {
* byte value. Optionally, also get a description of the DTC.
* Returns a static buffer that will be reused on the next call.
*/
static char *dtc_printable_by_raw(uint8_t addr, uint8_t raw, const char **desc) {
static char *dtc_printable_by_raw(uint8_t addr, uint8_t raw, const char **desc, const char **tips) {
#define PRINTABLE_LEN 8 //including 0-termination
static char printable[PRINTABLE_LEN];
static char *empty="";
const struct ecu_info *ecu_entry;
const struct dtc_table_entry *dtc_entry;
const struct dtc_table_entry *dtc_map;
const char *prefix;
uint16_t suffix;
int16_t suffix;

prefix = "???";
if (tips != NULL) {
*tips = NULL;
}
ecu_entry = ecu_info_by_addr(addr);
if (ecu_entry) {
prefix = ecu_entry->dtc_prefix;
Expand All @@ -254,10 +257,17 @@ static char *dtc_printable_by_raw(uint8_t addr, uint8_t raw, const char **desc)
if (desc != NULL) {
*desc = dtc_entry->desc;
}
if (tips != NULL) {
*tips = dtc_entry->tips;
}
if (suffix > 999) {
suffix = 999;
}
snprintf(printable, PRINTABLE_LEN, "%s-%03d", prefix, suffix);
if (suffix >= 0) {
snprintf(printable, PRINTABLE_LEN, "%s-%03d", prefix, suffix);
} else {
snprintf(printable, PRINTABLE_LEN, "%s-???", prefix);
}
return printable;
}
}
Expand Down Expand Up @@ -290,7 +300,7 @@ static const char *current_dtc_prefix(void) {

/*
* Get a DTC byte value by the printable designation. Returns 0xffff on
* failure.
* failure. Where multiple matching DTCs exist, returns the first.
*/
static uint16_t dtc_raw_by_printable(const char *printable) {
char prefix[8];
Expand Down Expand Up @@ -963,7 +973,7 @@ static enum cli_retval read_family(int argc, char **argv, enum l7_namespace ns)
dtc_printable_by_raw(
global_l2_conn
->diag_l2_destaddr,
addr, NULL));
addr, NULL, NULL));
}
if (gotbytes == 0) {
printf_livedata("%02X: no data", addr);
Expand Down Expand Up @@ -1367,9 +1377,18 @@ static enum cli_retval cmd_850_dtc(int argc, UNUSED(char **argv)) {
int i;
int span;
char *code;
const char *desc;
const char *desc, *tips;
bool unconfirmed = false;
bool have_tips = false;
bool show_tips = false;

if (!valid_arg_count(1, argc, 1)) {
if (!valid_arg_count(1, argc, 2)) {
return CMD_USAGE;
}

if (argc == 2 && strcasecmp(argv[1], "tips") == 0) {
show_tips = true;
} else if (argc == 2) {
return CMD_USAGE;
}

Expand Down Expand Up @@ -1398,8 +1417,29 @@ static enum cli_retval cmd_850_dtc(int argc, UNUSED(char **argv)) {

printf("Stored DTCs:\n");
for (i=0; i<rv; i+=span) {
code = dtc_printable_by_raw(global_l2_conn->diag_l2_destaddr, buf[i], &desc);
code = dtc_printable_by_raw(global_l2_conn->diag_l2_destaddr, buf[i], &desc, &tips);
printf("%s (%02X) %s\n", code, buf[i], desc);
if (desc[0] != '\0' && desc[strlen(desc)-1] == '?') {
unconfirmed = true;
}
if (tips != NULL) {
have_tips = true;
if (show_tips) {
printf("%s\n", tips);
}
}
}

if (unconfirmed) {
printf("Warning: descriptions and DTC suffixes for lines ending in ? are unconfirmed\n");
}

if (have_tips && !show_tips) {
printf("Tips are available for %s. Use \"dtc tips\" to show them.\n", (rv > span) ? "some of these DTCs" : "this DTC");
}

if (show_tips && !have_tips) {
printf("No tips are available for %s.\n", (rv > span) ? "these DTCs" : "this DTC");
}

return CMD_OK;
Expand Down
Loading