You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure. I prefer to return boolean, because interpretation has to be same for all backends.
In case it does sense, there could be more states, something like some interpretation table for all types, but return just what is in metadata is problematic in case it is not same for systemd-nspawn, docker, openshift, ... etc
Let me rephrase. This is the definition of the function:
defstatus(self):
""" Function returns whether the application exists and is Running in OpenShift environment :return: True application exists False application does not exist. """
The dictionaries define status as:
the situation at a particular time during a process
or
state or condition of affairs
I understand that definition of the word status is an enumeration of states. @jscotka you suggest that the enumeration should hold just two states: true and false. That's perfectly fine. But in my world, that implementation doesn't fit the status method.
So what I had in mind is:
either change the name and documentation of the method (e.g. def app_exists(self):)
or change the implementation
because the current state is confusing. And ideally use the python way of doing things: properties
In PR #164 we have discovered that status function returns boolean value.
Can we discuss it, whether we can return strings like "Running", "Failed", etc.?
Does it make sense at all?
The text was updated successfully, but these errors were encountered: