-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy python tests for Modulemd.ModuleIndexMerger into C #198
Comments
Hi! I am an outreachy applicant. Please guide me how to contribute. |
@SunitiJain Please see https://github.com/fedora-modularity/libmodulemd/blob/master/README.md#getting-started-with-developing for a basic introduction into developing libmodulemd. |
Can I work on this issue? I'm an outreachy applicant. |
Can you please assign me this issue. I have tried to make some updates. I am outreachy applicant. |
Is anyone working on this issue? |
I am working on this issue.
…On Sat, Mar 16, 2019, 10:10 AM athira-selvam ***@***.***> wrote:
Is anyone working on this issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApZ6dUER-nQOS3y9E_Jylw0ZeWWSQ0cjks5vXHXRgaJpZM4bTGMx>
.
|
Thanks .
…On Wed, Feb 27, 2019, 6:17 PM Stephen Gallagher ***@***.***> wrote:
@SunitiJain <https://github.com/SunitiJain> Please see
https://github.com/fedora-modularity/libmodulemd/blob/master/README.md#getting-started-with-developing
for a basic introduction into developing libmodulemd.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AssFWNdlYwjaWmaBuwx8ciYJtyPgx8d4ks5vRn5QgaJpZM4bTGMx>
.
|
@sgallagher I am Outreachy applicant and I have already started working on this issue . Can this issued be assigned to me as well? |
Only strict_default_streams is left to copy in this. (specifying so that I don't have to look through the files again) |
Currently, most of the tests for the merge logic are run under Python. The valgrind tests for identifying memory leaks and errors can only run against tests in the C code. We need to replicate the python tests as C tests.
This would be a good task for a newcomer to the project. Look at the tests being run in
modulemd/v2/tests/ModulemdTests/merger.py
and copy them intomodulemd/v2/tests/test-modulemd-merger.c
This will ensure that these code-paths are scanned with valgrind for leaks when
ninja test
is run (and when the CI test suite is executed).The text was updated successfully, but these errors were encountered: