Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy python tests for Modulemd.ModuleIndexMerger into C #198

Open
sgallagher opened this issue Feb 26, 2019 · 9 comments
Open

Copy python tests for Modulemd.ModuleIndexMerger into C #198

sgallagher opened this issue Feb 26, 2019 · 9 comments
Labels
good first issue Easy tickets suitable for a new contributor

Comments

@sgallagher
Copy link
Collaborator

Currently, most of the tests for the merge logic are run under Python. The valgrind tests for identifying memory leaks and errors can only run against tests in the C code. We need to replicate the python tests as C tests.

This would be a good task for a newcomer to the project. Look at the tests being run in modulemd/v2/tests/ModulemdTests/merger.py and copy them into modulemd/v2/tests/test-modulemd-merger.c

This will ensure that these code-paths are scanned with valgrind for leaks when ninja test is run (and when the CI test suite is executed).

@sgallagher sgallagher added the good first issue Easy tickets suitable for a new contributor label Feb 26, 2019
@ghost
Copy link

ghost commented Feb 27, 2019

Hi! I am an outreachy applicant. Please guide me how to contribute.

@sgallagher
Copy link
Collaborator Author

@SunitiJain Please see https://github.com/fedora-modularity/libmodulemd/blob/master/README.md#getting-started-with-developing for a basic introduction into developing libmodulemd.

@Madhumitha
Copy link

Can I work on this issue? I'm an outreachy applicant.

@AarushiSingh09
Copy link
Contributor

Can you please assign me this issue. I have tried to make some updates. I am outreachy applicant.

@athira-selvam
Copy link
Contributor

Is anyone working on this issue?

@AarushiSingh09
Copy link
Contributor

AarushiSingh09 commented Mar 16, 2019 via email

@ghost
Copy link

ghost commented Mar 18, 2019 via email

@yashpupneja
Copy link

@sgallagher I am Outreachy applicant and I have already started working on this issue . Can this issued be assigned to me as well?

@OrionStar25
Copy link
Member

OrionStar25 commented Jan 23, 2020

Only strict_default_streams is left to copy in this. (specifying so that I don't have to look through the files again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy tickets suitable for a new contributor
Projects
None yet
Development

No branches or pull requests

6 participants