Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEM-PKCS#1 besides PEM-SPKI for RSA public keys #209

Closed
dahlia opened this issue Feb 18, 2025 · 1 comment
Closed

Support PEM-PKCS#1 besides PEM-SPKI for RSA public keys #209

dahlia opened this issue Feb 18, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dahlia
Copy link
Member

dahlia commented Feb 18, 2025

Although the vast majority of ActivityPub software encodes RSA public keys in PEM-SPKI format, some software encodes RSA public keys in PEM-PKCS#1 format (see: fedify-dev/hollo#109 (comment)). Fedify currently only accepts PEM-SPKI format, so it needs to accept PEM-PKCS#1 format as well for better interoperability.

@dahlia dahlia added the enhancement New feature or request label Feb 18, 2025
@dahlia
Copy link
Member Author

dahlia commented Feb 18, 2025

Fortunately, using Node.js's node:crypto module, it is possible to convert an RSA public key encoded in PEM-PKCS#1 to PEM-SPKI.

@dahlia dahlia self-assigned this Feb 18, 2025
@dahlia dahlia closed this as completed in b516691 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant