Merge pull request #635 from dahlia/fix/externalize-fedify-fixture-in-tsdown

Mark `@fedify/fixture` as external in test build configs

Author: dahlia

docs/cli.md

@@ -244,19 +244,19 @@ project.  It will ask you a few questions to set up the project:
 Alternatively, you can specify the options in the command line to skip some of
 interactive prompts:
 
-[npm]: https://www.npmjs.com/
-[pnpm]: https://pnpm.io/
-[Yarn]: https://yarnpkg.com/
 [Hono]: https://hono.dev/
 [Elysia]: https://elysiajs.com/
 [Express]: https://expressjs.com/
 [Nitro]: https://nitro.unjs.io/
 [Next.js]: https://nextjs.org/
+[npm]: https://www.npmjs.com/
+[pnpm]: https://pnpm.io/
+[Yarn]: https://yarnpkg.com/
 [Redis]: https://redis.io/
 [PostgreSQL]: https://www.postgresql.org/
-[Deno KV]: https://deno.com/kv
 [AMQP]: https://www.amqp.org/
 [RabbitMQ]: https://www.rabbitmq.com/
+[Deno KV]: https://deno.com/kv
 [`@fedify/lint`]: /manual/lint
 [`@fedify/create`]: https://www.npmjs.com/package/@fedify/create
 
@@ -282,7 +282,7 @@ the `-w`/`--web-framework` option.  The available options are:
  -  `elysia`: [Elysia]
  -  `express`: [Express]
 
-### `-k`/`--kv-store`: Key–value store
+### `-k`/`--kv-store`: key–value store
 
 You can specify the key–value store to use by using the `-k`/`--kv-store`
 option.  The available options are:

packages/fedify/tsdown.config.ts

@@ -40,7 +40,15 @@ export default [
       ...(await Array.fromAsync(glob(`src/**/*.test.ts`)))
         .map((f) => f.replace(sep, "/")),
     ],
-    external: [/^node:/],
+    external: [/^node:/, "@fedify/fixture"],
+    // Bundle @fedify/fixture back in for src/testing/ files (needed for
+    // cfworkers), while keeping it external for test files so that
+    // pnpm pack --recursive does not try to resolve the private package:
+    noExternal: (id: string, importer: string | undefined) => {
+      if (id !== "@fedify/fixture") return false;
+      const normalized = importer?.replaceAll(sep, "/");
+      return normalized?.includes("/src/testing/") ?? false;
+    },
     inputOptions: {
       onwarn(warning, defaultHandler) {
         if (

packages/vocab-runtime/tsdown.config.ts

@@ -16,6 +16,6 @@ export default [
       .map((f) => f.replace(sep, "/")),
     format: ["esm", "cjs"],
     platform: "node",
-    external: [/^node:/],
+    external: [/^node:/, "@fedify/fixture"],
   }),
 ];

packages/vocab/tsdown.config.ts

@@ -27,7 +27,7 @@ export default [
   defineConfig({
     entry: (await Array.fromAsync(glob(`src/**/*.test.ts`)))
       .map((f) => f.replace(sep, "/")),
-    external: [/^node:/],
+    external: [/^node:/, "@fedify/fixture"],
     inputOptions: {
       onwarn(warning, defaultHandler) {
         if (

packages/webfinger/tsdown.config.ts

@@ -15,6 +15,6 @@ export default [
       .map((f) => f.replace(sep, "/")),
     format: ["esm", "cjs"],
     platform: "node",
-    external: [/^node:/],
+    external: [/^node:/, "@fedify/fixture"],
   }),
 ];