Skip to content

Commit 9f9263e

Browse files
Squashed commit for rebase
Signed-off-by: lrangine <[email protected]>
1 parent 355da16 commit 9f9263e

File tree

8 files changed

+5173
-1376
lines changed

8 files changed

+5173
-1376
lines changed

infra/feast-operator/api/v1alpha1/featurestore_types.go

+9-2
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ type FeatureStoreServices struct {
7878
DeploymentStrategy *appsv1.DeploymentStrategy `json:"deploymentStrategy,omitempty"`
7979
// Disable the 'feast repo initialization' initContainer
8080
DisableInitContainers bool `json:"disableInitContainers,omitempty"`
81+
// Volumes specifies the volumes to mount in the FeatureStore deployment. A corresponding `VolumeMount` should be added to whichever feast service(s) require access to said volume(s).
82+
Volumes []corev1.Volume `json:"volumes,omitempty"`
8183
}
8284

8385
// OfflineStore configures the deployed offline store service
@@ -141,7 +143,7 @@ type OnlineStorePersistence struct {
141143
DBPersistence *OnlineStoreDBStorePersistence `json:"store,omitempty"`
142144
}
143145

144-
// OnlineStoreFilePersistence configures the file-based persistence for the offline store service
146+
// OnlineStoreFilePersistence configures the file-based persistence for the online store service
145147
// +kubebuilder:validation:XValidation:rule="(!has(self.pvc) && has(self.path)) ? self.path.startsWith('/') : true",message="Ephemeral stores must have absolute paths."
146148
// +kubebuilder:validation:XValidation:rule="(has(self.pvc) && has(self.path)) ? !self.path.startsWith('/') : true",message="PVC path must be a file name only, with no slashes."
147149
// +kubebuilder:validation:XValidation:rule="has(self.path) ? !(self.path.startsWith('s3://') || self.path.startsWith('gs://')) : true",message="Online store does not support S3 or GS buckets."
@@ -150,7 +152,7 @@ type OnlineStoreFilePersistence struct {
150152
PvcConfig *PvcConfig `json:"pvc,omitempty"`
151153
}
152154

153-
// OnlineStoreDBStorePersistence configures the DB store persistence for the offline store service
155+
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
154156
type OnlineStoreDBStorePersistence struct {
155157
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase;milvus
156158
Type string `json:"type"`
@@ -283,6 +285,11 @@ type ServerConfigs struct {
283285
// Allowed values: "debug", "info", "warning", "error", "critical".
284286
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
285287
LogLevel string `json:"logLevel,omitempty"`
288+
// VolumeMounts defines the list of volumes that should be mounted into the feast container.
289+
// This allows attaching persistent storage, config files, secrets, or other resources
290+
// required by the Feast components. Ensure that each volume mount has a corresponding
291+
// volume definition in the Volumes field.
292+
VolumeMounts []corev1.VolumeMount `json:"volumeMounts,omitempty"`
286293
}
287294

288295
// ContainerConfigs k8s container settings for the server

infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go

+14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)