exposed manifest to independent API consumers #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this saves them the trouble of redundantly reading and deserializing the manifest file this assumes that so far nobody uses * ... `faucetDispatch`'s return value, other than waiting for completion * ... `Manifest`'s `toJSON` method because that class was never exposed
FND
commented
Nov 21, 2025
| return res.then(() => ({ | ||
| get manifest() { | ||
| return assetManager.manifest.entries; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This might be dangerously misleading: If consumers cache this value, they're gonna be working with an outdated manifest:
let { manifest } = await faucetDispatch(…);
await faucetDispatch(…);
console.log(manifest);Here manifest ends up being a stale copy, not the live object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus removed a (hopefully) obsolete polyfill