From b15e98d2d8a11f7d40ec9ed2d84d9e5cb35cbd43 Mon Sep 17 00:00:00 2001 From: Roger Oba <rogerluan.oba@gmail.com> Date: Fri, 21 Jan 2022 23:03:11 -0300 Subject: [PATCH 1/4] Fix typos. --- docs/best-practices/xcodebuild-formatters.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/best-practices/xcodebuild-formatters.md b/docs/best-practices/xcodebuild-formatters.md index 1c87d9377..fa682dfc2 100644 --- a/docs/best-practices/xcodebuild-formatters.md +++ b/docs/best-practices/xcodebuild-formatters.md @@ -55,16 +55,16 @@ $ xcodebuild [flags] | <xcodebuild_formatter> $ brew install xcbeautify ``` -`xcbeautify` is the recommended because: - - - Faster than `xcpretty` +`xcbeautify` is the recommended one because it: + - Supports Xcode's new build system output - - Supports Xcode's parallel testing output + - Supports Xcode's parallel testing output - Supports formatting Swift Package Manager output + - It's faster than `xcpretty` #### xcpretty -Historticaly, _fastlane_ was tightly integrated with [xcpretty](https://github.com/xcpretty/xcpretty). `xcpretty` is a RubyGem and a dependency of _fastlane_. This was the best option for _fastlane_ as there were no extra steps for installing or using this formatter. +Historically, _fastlane_ was tightly integrated with [xcpretty](https://github.com/xcpretty/xcpretty). `xcpretty` is a RubyGem and a dependency of _fastlane_. This was the best option for _fastlane_ as there were no extra steps for installing or using this formatter. `xcpretty` also did more than formatting. It used the `xcodebuild` output to: From a0f6becd8e2d2924ed50bc0d5377ff2fc32b9b6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Bra=C5=A1na?= <1784648+janbrasna@users.noreply.github.com> Date: Thu, 24 Feb 2022 14:18:12 +0100 Subject: [PATCH 2/4] Fix typos --- docs/best-practices/xcodebuild-formatters.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/best-practices/xcodebuild-formatters.md b/docs/best-practices/xcodebuild-formatters.md index fa682dfc2..80ffcd588 100644 --- a/docs/best-practices/xcodebuild-formatters.md +++ b/docs/best-practices/xcodebuild-formatters.md @@ -26,12 +26,12 @@ scan( xcodebuild_formatter: "xcpretty" ) -# Specificy a local install of xcbeautify +# Specify a local install of xcbeautify scan( xcodebuild_formatter: "/custom/path/to/xcbeautify" ) -# Specifify your own custom formatter +# Specify your own custom formatter scan( xcodebuild_formatter: "/custom/path/to/my_formatter" ) @@ -72,5 +72,5 @@ Historically, _fastlane_ was tightly integrated with [xcpretty](https://github.c - Generate an HTML report - Generate a JSON compilation database -**Before 2.201.0**, [_scan_](/actions/scan/) used `xcpretty` to generate these files and determine success/failure with `xcpretty` output -<br/>**As of 2.201.0**, [_scan_](/actions/scan/) will only generate these if `xcodebuild_formatter` is using `xcpretty` but now use `trainer` to parse test results to determine success/failure +**Before 2.201.0**, [_scan_](/actions/scan/) used `xcpretty` to generate these files and determine success/failure with `xcpretty` output.<br/> +**As of 2.201.0**, [_scan_](/actions/scan/) will only generate these if `xcodebuild_formatter` is using `xcpretty` but now use `trainer` to parse test results to determine success/failure. From e2777e65cb7781c83a4d27b7ef6ab4423ce8ca74 Mon Sep 17 00:00:00 2001 From: Roger Oba <rogerluan.oba@gmail.com> Date: Thu, 24 Feb 2022 10:38:01 -0300 Subject: [PATCH 3/4] Improve wording. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jan Brašna <1784648+janbrasna@users.noreply.github.com> --- docs/best-practices/xcodebuild-formatters.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/best-practices/xcodebuild-formatters.md b/docs/best-practices/xcodebuild-formatters.md index fa682dfc2..fc3badf6d 100644 --- a/docs/best-practices/xcodebuild-formatters.md +++ b/docs/best-practices/xcodebuild-formatters.md @@ -55,7 +55,7 @@ $ xcodebuild [flags] | <xcodebuild_formatter> $ brew install xcbeautify ``` -`xcbeautify` is the recommended one because it: +`xcbeautify` is currently recommended because it: - Supports Xcode's new build system output - Supports Xcode's parallel testing output From 40a1948e0a32d753a0367ca17b0d0f256287ba2b Mon Sep 17 00:00:00 2001 From: Roger Oba <rogerluan.oba@gmail.com> Date: Sun, 3 Jul 2022 19:19:46 -0300 Subject: [PATCH 4/4] Update list wording. --- docs/best-practices/xcodebuild-formatters.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/best-practices/xcodebuild-formatters.md b/docs/best-practices/xcodebuild-formatters.md index 959e3793c..580373f2f 100644 --- a/docs/best-practices/xcodebuild-formatters.md +++ b/docs/best-practices/xcodebuild-formatters.md @@ -55,11 +55,11 @@ $ xcodebuild [flags] | <xcodebuild_formatter> $ brew install xcbeautify ``` -`xcbeautify` is currently recommended because it: +`xcbeautify` is currently recommended: - - Supports Xcode's new build system output - - Supports Xcode's parallel testing output - - Supports formatting Swift Package Manager output + - It supports Xcode's new build system output + - It supports Xcode's parallel testing output + - It supports formatting Swift Package Manager output - It's faster than `xcpretty` #### xcpretty