Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(tests): fix emscripten build #2184

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind failing-test

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97
Copy link
Member Author

Andreagit97 commented Dec 4, 2024

i don't know what is broken, i've just made an attempt since these errors are usually around missing casts. If this doesn't work i will probably revert the test changed here #2181 and leave the issue for another day since it is better to have the master CI green

Copy link

github-actions bot commented Dec 4, 2024

Perf diff from master - unit tests

     5.94%     -1.65%  [.] next
     1.92%     -0.87%  [.] sinsp_evt_filter::sinsp_evt_filter
     1.51%     +0.72%  [.] scap_event_decode_params
     2.72%     +0.60%  [.] sinsp_thread_manager::get_thread_ref
     2.98%     +0.59%  [.] gzfile_read
     9.91%     -0.53%  [.] sinsp_parser::reset
     7.75%     +0.47%  [.] sinsp::next
     1.31%     -0.44%  [.] sinsp_parser::event_cleanup
     1.21%     -0.44%  [.] sinsp_evt::get_direction
     0.45%     +0.44%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0024         +0.0023           151           151           151           151
BM_sinsp_split_median                                          +0.0045         +0.0045           151           151           151           151
BM_sinsp_split_stddev                                          +0.3531         +0.3541             1             2             1             2
BM_sinsp_split_cv                                              +0.3499         +0.3510             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0037         -0.0037            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_median                -0.0015         -0.0015            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8850         -0.8850             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8846         -0.8846             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0457         -0.0457            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0447         -0.0447            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5411         -0.5395             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5192         -0.5175             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0280         -0.0280            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_median                -0.0144         -0.0144            63            63            63            63
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8874         -0.8870             2             0             2             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.8841         -0.8837             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0091         -0.0091           395           392           395           391
BM_sinsp_split_container_image_median                          -0.0121         -0.0121           397           392           397           392
BM_sinsp_split_container_image_stddev                          -0.1069         -0.1073             4             3             4             3
BM_sinsp_split_container_image_cv                              -0.0987         -0.0991             0             0             0             0

@Andreagit97
Copy link
Member Author

Andreagit97 commented Dec 4, 2024

reverted the old test to fix the CI

@poiana
Copy link
Contributor

poiana commented Dec 4, 2024

LGTM label has been added.

Git tree hash: 32b9eb6ce0c2548090b2de5ded03808a7580e1c3

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
But...why? 🤣

@poiana
Copy link
Contributor

poiana commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit be9c2de into falcosecurity:master Dec 4, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants