-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): introduce a new test helper #2181
Conversation
ba2a590
to
02b538d
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
02b538d
to
247a938
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2181 +/- ##
=======================================
Coverage 75.16% 75.16%
=======================================
Files 257 257
Lines 33736 33736
Branches 5755 5755
=======================================
Hits 25359 25359
Misses 8377 8377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
no idea why this is failing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: c5e0ce2ed1ebcdcc3dc55ad6fe032ba798fe61cc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR introduces a new test helper. I had this helper in an old branch and it will become really useful when sinsp won't need any more
OPEN_E
event to populate the state.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: