Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move utils to the correct place #2961

Open
ST-DDT opened this issue Jun 20, 2024 · 1 comment · May be fixed by #2964
Open

Move utils to the correct place #2961

ST-DDT opened this issue Jun 20, 2024 · 1 comment · May be fixed by #2964
Assignees
@watercubz
Labels
c: chore PR that doesn't affect the runtime behavior good first issue Good for newcomers p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jun 20, 2024

Based on our team meeting:

We will put internal utilities in src/internal/*.ts
We will put external utilities in src/utils/*.ts
External utilities will be exported from the root of our library.
External utilities are not required to use a faker seed.

TODOs:

  • Move generateMersenne*Randomizers() to src/utils
  • Move src/utils/types.ts to src/internal/
@ST-DDT ST-DDT added good first issue Good for newcomers c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Jun 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 20, 2024
watercubz added a commit to watercubz/faker that referenced this issue Jun 22, 2024
@watercubz
Move functions and types as per issue faker-js#2961
665358f
watercubz added a commit to watercubz/faker that referenced this issue Jun 22, 2024
@watercubz
Move functions and types as per issue faker-js#2961
9cdb9f7
@watercubz watercubz linked a pull request Jun 22, 2024 that will close this issue
Draft
@ST-DDT ST-DDT linked a pull request Jun 22, 2024 that will close this issue
fix: move utils to the correct place #2964
Draft
@watercubz
Copy link

Hi team,

I understand, I have already solved the problem and in a moment I will upload the changes for code review. If you have another request regarding the issue, I am here.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watercubz watercubz

Labels
c: chore PR that doesn't affect the runtime behavior good first issue Good for newcomers p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

fix: move utils to the correct place watercubz/faker
2 participants
@ST-DDT @watercubz