Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Intl based tests for date definitions #2904

Closed
ST-DDT opened this issue May 16, 2024 · 4 comments
Closed

Create Intl based tests for date definitions #2904

ST-DDT opened this issue May 16, 2024 · 4 comments
Assignees
@sossost
Labels
c: test m: date Something is referring to the date module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@ST-DDT
Copy link
Member

ST-DDT commented May 16, 2024

To ensure the completeness of the weekdays and months, we should have tests that ensure we have the correct values.

Originally posted by @ST-DDT in #2902 (comment)
@ST-DDT ST-DDT added good first issue Good for newcomers p: 1-normal Nothing urgent c: test m: date Something is referring to the date module labels May 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 16, 2024
@sossost
Copy link

sossost commented May 17, 2024

Hi! @ST-DDT I'm sossost, a new contributor. I would like to solve this issue.

@ST-DDT
Copy link
Member Author

ST-DDT commented May 17, 2024

I assigned it to you. Thanks for your help.

@xDivisionByZerox
Copy link
Member

Hi! @ST-DDT I'm sossost, a new contributor. I would like to solve this issue.

Thank you for your interest in tackling this issue ❤️

We currently try to further improve our contribution documentation to enhance the DX for new contributors. Feel free to inform us if you get stuck while working on this issue and can't find documentation in the current contribution guides that would resolve your problem.

@ST-DDT ST-DDT linked a pull request May 18, 2024 that will close this issue
test(date): Add Intl-Based Tests for Date Definitions to Ensure Completeness of Weekdays and Months #2912
Closed
@sossost sossost mentioned this issue May 18, 2024
Closed
@xDivisionByZerox xDivisionByZerox removed the good first issue Good for newcomers label Aug 7, 2024
@xDivisionByZerox
Copy link
Member

We close this as not planed: #2912 (comment)

@xDivisionByZerox xDivisionByZerox closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sossost sossost

Labels
c: test m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
3 participants
@ST-DDT @xDivisionByZerox @sossost