Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle data is very US-centric #2881

Closed
matthewmayer opened this issue May 6, 2024 · 1 comment · Fixed by #3173
Closed

Vehicle data is very US-centric #2881

matthewmayer opened this issue May 6, 2024 · 1 comment · Fixed by #3173
Assignees
@matthewmayer
Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented May 6, 2024 •
edited
Loading

i noticed in #2874 that the vehicle data is heavily US-centric, mostly featuring US manufacturers and US models, whereas the generic en locale is supposed to cover all English-speaking regions. Once #2874 is merged i can follow up with a new PR to add some more popular missing brands popular in US, UK, India e.g.

  • Subaru
  • Mitsubishi
  • Peugeot
  • Citroën
  • Suzuki
  • Renault

Plus some EV manufacturers like

  • BYD
  • NIO
  • Rivian
@matthewmayer matthewmayer self-assigned this May 6, 2024
@matthewmayer matthewmayer added m: vehicle Something is referring to the vehicle module c: locale Permutes locale definitions p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts labels May 6, 2024
@xDivisionByZerox
Copy link
Member

I appreciate all the work you put into creating all these tickets with things you noticed during the data normalization PRs. Big thank you from my side 🙏

matthewmayer added a commit that referenced this issue Oct 12, 2024
@matthewmayer
feat(vehicle): add more non-US vehicle manufacturers
efe8448 
fix #2881
@matthewmayer matthewmayer mentioned this issue Oct 12, 2024
Merged
@suyashgulati suyashgulati mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(vehicle): add more non-US vehicle manufacturers faker-js/faker
2 participants
@matthewmayer @xDivisionByZerox